Skip to content

refactor: consolidate agent config into agents directory#27427

Merged
eunjae-lee merged 7 commits intomainfrom
eunjae-lee/check-cursor-rules
Feb 3, 2026
Merged

refactor: consolidate agent config into agents directory#27427
eunjae-lee merged 7 commits intomainfrom
eunjae-lee/check-cursor-rules

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee commented Jan 30, 2026

What does this PR do?

Consolidated duplicate agent configuration folders (.claude, .cursor, .goose) into a single source of truth under agents/. Removed 149 duplicate files across .cursor and .goose, then created symlinks to point to the canonical files in agents/.

Changes:

  • Move .claude/skills/agents/skills/
  • Remove duplicate .cursor/ and .goose/ folders entirely
  • Create symlinks from .claude/ and .cursor/ to agents/
  • Convert review.mdc to quality-review-checklist.md with proper frontmatter

New structure:

.claude/
├── rules -> ../agents/rules
└── skills -> ../agents/skills

.cursor/
├── rules -> ../agents/rules
└── skills -> ../agents/skills

Reduces maintenance burden by eliminating duplicate files and ensures all tools reference the same definitions.

Updates since last revision

  • Added Cal.com API v2 skills from PR feat: add Cal.com APIv2 skills for AI agents #27445 into the consolidated agents/skills/ directory structure:
    • agents/skills/calcom-api/SKILL.md - Main skill file (concise index)
    • agents/skills/calcom-api/references/ - Detailed API reference docs (authentication, bookings, calendars, event-types, schedules, slots-availability, webhooks)
  • Updated calcom-api SKILL.md frontmatter to follow Claude Code skills specification (removed non-standard license and metadata fields)
  • Restructured SKILL.md from a comprehensive 317-line doc to a concise 118-line index file that references the detailed documentation in the references/ folder
  • Preserved all removed content by moving it to appropriate reference files:
    • Added Error Handling and Pagination sections to authentication.md
    • Added Organization endpoints to event-types.md
    • Added Core Concepts section back to SKILL.md

This ensures the API v2 skills follow the same consolidated structure rather than existing in a separate root skills/ folder.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - internal tooling only.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. N/A - no code changes, only file reorganization.

How should this be tested?

  1. Clone the branch
  2. Verify symlinks work: ls -la .claude/ and ls -la .cursor/
  3. Verify files are accessible through symlinks: ls .claude/rules/ should show the rules from agents/rules/
  4. Verify calcom-api skills are accessible: ls .claude/skills/calcom-api/ should show SKILL.md and references/

Human Review Checklist

  • Verify symlinks resolve correctly on your platform (especially Windows)
  • Confirm calcom-api SKILL.md frontmatter follows Claude Code skills spec (only name and description fields)
  • Verify SKILL.md properly references all 7 files in the references/ folder
  • Verify no useful API documentation was lost - check that Error Handling, Pagination, Organization endpoints, and Core Concepts are present in the appropriate files
  • Check that no duplicate files remain in .cursor/ or .goose/ directories

- Move .claude/skills and .claude/rules content to agents/
- Remove duplicate .cursor/ and .goose/ folders
- Create symlinks from .claude/ and .cursor/ to agents/
- Convert review.mdc to quality-review-checklist.md with proper frontmatter

Co-Authored-By: Claude Haiku 4.5 <[email protected]>
@graphite-app graphite-app bot added the core area: core, team members only label Jan 30, 2026
@graphite-app graphite-app bot requested review from a team January 30, 2026 10:33
@eunjae-lee eunjae-lee marked this pull request as draft January 30, 2026 10:33
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 149 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@eunjae-lee eunjae-lee marked this pull request as ready for review January 30, 2026 15:23
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 149 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@Amit91848
Copy link
Copy Markdown
Member

#27445

Peer created a new skills folder for api v2, we should move these as well

devin-ai-integration bot and others added 4 commits February 2, 2026 09:50
Move the Cal.com API v2 skills from PR #27445 into the consolidated
agents/skills/ directory structure. This includes:
- SKILL.md - Main skill file with API overview
- references/authentication.md - Authentication methods
- references/bookings.md - Bookings API reference
- references/calendars.md - Calendars API reference
- references/event-types.md - Event types API reference
- references/schedules.md - Schedules API reference
- references/slots-availability.md - Slots and availability API reference
- references/webhooks.md - Webhooks API reference

Co-Authored-By: [email protected] <[email protected]>
Remove non-standard frontmatter fields (license, metadata) and keep only
the Claude Code supported fields (name, description) as per the
Claude Code skills specification.

Co-Authored-By: [email protected] <[email protected]>
Convert SKILL.md from a comprehensive API doc (317 lines) to a concise
index file (108 lines) that references the detailed documentation in
the references/ folder. This follows the Claude Code skills pattern of
keeping SKILL.md focused with supporting files for detailed content.

The SKILL.md now:
- Provides a quick start guide with essential examples
- References all 7 detailed reference docs in a table
- Lists common workflows and best practices
- Points to external resources

Co-Authored-By: [email protected] <[email protected]>
Move content that was removed from SKILL.md to appropriate reference files:
- Add Error Handling and Pagination sections to authentication.md
- Add Organization endpoints to event-types.md
- Add Core Concepts section back to SKILL.md

This ensures no useful API documentation is lost during the restructuring.

Co-Authored-By: [email protected] <[email protected]>
@eunjae-lee
Copy link
Copy Markdown
Contributor Author

#27445

Peer created a new skills folder for api v2, we should move these as well

done !

Copy link
Copy Markdown
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up. I have some thoughts:

  1. We currently have AGENTS.md and README.md and there is duplication:
select over include → detailed in rules/data-prefer-select-over-include.md
credential.key security rule → in coding-standards.md and CLAUDE.md
Avoid O(n²) logic → in rules/performance-avoid-quadratic.md
Minimize Day.js → in rules/performance-dayjs-usage.md
Early returns → in coding-standards.md and CLAUDE.md
PR size limits → in CLAUDE.md

Maybe we delete duplication and then what is left from README.md move to knowledge-base.md?
2. maybe we can also add docs for developers explaining our ai setup in the root monorepo README.md? That we have local agents folder and that we mainly use cursor and claude so we have symlinks, and then we rely on rules, skills and main agent files like claude.md

What do you think?

@eunjae-lee
Copy link
Copy Markdown
Contributor Author

eunjae-lee commented Feb 3, 2026

Nice clean up. I have some thoughts:

1. We currently have AGENTS.md and README.md and there is duplication:
select over include → detailed in rules/data-prefer-select-over-include.md
credential.key security rule → in coding-standards.md and CLAUDE.md
Avoid O(n²) logic → in rules/performance-avoid-quadratic.md
Minimize Day.js → in rules/performance-dayjs-usage.md
Early returns → in coding-standards.md and CLAUDE.md
PR size limits → in CLAUDE.md

Maybe we delete duplication and then what is left from README.md move to knowledge-base.md? 2. maybe we can also add docs for developers explaining our ai setup in the root monorepo README.md? That we have local agents folder and that we mainly use cursor and claude so we have symlinks, and then we rely on rules, skills and main agent files like claude.md

What do you think?

@supalarry you know what. actually i have another PR (#26994) that is already touching AGENTS.md, so let me apply that changes over there, and let this PR purely on cleaning up agent config folders.

@supalarry supalarry self-requested a review February 3, 2026 09:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

E2E results are ready!

@eunjae-lee eunjae-lee merged commit 12abc31 into main Feb 3, 2026
49 checks passed
@eunjae-lee eunjae-lee deleted the eunjae-lee/check-cursor-rules branch February 3, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants