perf: optimize getBusyTimesForLimitChecks with batched parallel queries by Udit-takkar · Pull Request #27399 · calcom/cal.com

Udit-takkar · 2026-01-29T17:55:18Z

What does this PR do?

TODO

Do we need to add one more index @@index([eventTypeId, userId, status, startTime]) on Booking Table?
Not required as we already have other index and it does a index scan when i ran the query

Optimizes the getBusyTimesForLimitChecks query in BusyTimesService which can be slow for teams/orgs with many members due to the userId: { in: userIds } clause.

Changes:

Splits large userIds arrays into batches of 50 and runs queries in parallel
Adds comprehensive unit tests for the batching logic (12 new tests)

This addresses performance concerns for organizations with hundreds of team members where the original single query with a large IN clause could cause slow query planning and execution.

Link to Devin run: https://app.devin.ai/sessions/0f1730edf1a14b2184c4b9bfb9c556d4
Requested by: @Udit-takkar

Updates since last revision

Fixed PII logging issue: Changed debug log at line 368 from JSON.stringify(busyTimes) to count=${busyTimes.length} to avoid exposing userId in logs (addressed Cubic AI review feedback, confidence 9/10)

Link to Devin run (Cubic fix): https://app.devin.ai/sessions/a16fb642ff984783a46e24f5e2aed4e3

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Unit tests: Run TZ=UTC yarn test packages/features/busyTimes/services/getBusyTimes.test.ts to verify all 15 tests pass (3 existing + 12 new)
Functional testing: Create a team event type with booking limits enabled and multiple team members. Verify that:
- Booking limits are still correctly enforced
- Rescheduling works correctly (the rescheduleUid exclusion)
- The busy times returned match the expected bookings
Performance testing (optional but recommended):
- Test with a large team (100+ members) and compare query times before/after
- Monitor database query logs to verify batching is working

Checklist

I have read the contributing guide
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have checked if my changes generate no new warnings

Human Review Checklist

Verify the raw SQL is semantically equivalent to the original Prisma query
Verify the hardcoded status = 'accepted' string matches BookingStatus.ACCEPTED enum value
Review that the batch size of 50 is appropriate for the expected use cases

…es and raw SQL Co-Authored-By: [email protected] <[email protected]>

devin-ai-integration · 2026-01-29T17:55:22Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI' or '@devin'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

…imization Co-Authored-By: [email protected] <[email protected]>

The batching (50 user chunks) and parallel execution (Promise.all) provide the main performance optimization. Using findMany instead of $queryRaw maintains the same performance characteristics while being compatible with prismock for testing. Co-Authored-By: [email protected] <[email protected]>

…hecks

cubic-dev-ai

1 issue found across 3 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/features/busyTimes/services/getBusyTimes.ts">

<violation number="1" location="packages/features/busyTimes/services/getBusyTimes.ts:368">
P1: Rule violated: **Avoid Logging Sensitive Information**

This log serializes busyTimes including `userId`, which exposes PII in logs. Avoid logging user identifiers; log only aggregate counts or remove the busyTimes payload.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

packages/features/busyTimes/services/getBusyTimes.ts

github-actions · 2026-02-05T10:23:18Z

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

Replace JSON.stringify(busyTimes) with count to avoid exposing userId in logs. Addresses Cubic AI review feedback (confidence 9/10). Co-Authored-By: unknown <>

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/features/busyTimes/services/getBusyTimes.ts">

<violation number="1" location="packages/features/busyTimes/services/getBusyTimes.ts:368">
P1: Rule violated: **Avoid Logging Sensitive Information**

Avoid logging sensitive data: JSON.stringify(busyTimes) includes per-booking userId values, which are PII, and should not be written to logs. Log only aggregate counts or non-identifying metadata per the "Avoid Logging Sensitive Information" rule.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

packages/features/busyTimes/services/getBusyTimes.ts

paragon-review · 2026-02-05T10:39:35Z

Paragon: tests updated

2 updated tests generated for this PR.

Updated Tests

getBusyTimesForLimitChecks integration tests — Integration tests for getBusyTimesForLimitChecks with real database - tests batching across multiple users and rescheduleUid exclusion
getBusyTimesForLimitChecks tests — Adding new test to existing file

Details

Updated Tests

getBusyTimesForLimitChecks integration tests (unit)
getBusyTimesForLimitChecks tests (unit)

github-actions · 2026-02-05T10:39:57Z

Devin AI is addressing Cubic AI's review feedback

New feedback has been sent to the existing Devin session.

View Devin Session

✅ No changes pushed (PR owner explicitly requested to keep the logging in comments here and here)

volnei

🚀

volnei · 2026-02-10T15:41:36Z

packages/features/busyTimes/services/getBusyTimes.ts

@@ -351,10 +466,10 @@ export class BusyTimesService {
      status: BookingStatus.ACCEPTED,
      // FIXME: bookings that overlap on one side will never be counted


👀 should we take care of it in this PR? or link a issue... I know it's old but since we're touching it 🙂

perf: optimize getBusyTimesForLimitChecks with batched parallel queri…

798ce40

…es and raw SQL Co-Authored-By: [email protected] <[email protected]>

pull-request-size bot added the size/L label Jan 29, 2026

devin-ai-integration bot and others added 2 commits January 29, 2026 18:03

test: add unit tests for getBusyTimesForLimitChecks batched query opt…

a030160

…imization Co-Authored-By: [email protected] <[email protected]>

Udit-takkar changed the title ~~perf: optimize getBusyTimesForLimitChecks with batched parallel queries and raw SQL~~ perf: optimize getBusyTimesForLimitChecks with batched parallel queries Jan 29, 2026

fix: type error

14fce1a

keithwillcode added the core area: core, team members only label Feb 3, 2026

Udit-takkar and others added 2 commits February 5, 2026 14:21

Merge branch 'main' into devin/1769709003-optimize-busy-times-limit-c…

312e3da

…hecks

refactor: add integration test

5a6f553

pull-request-size bot added size/XL and removed size/L labels Feb 5, 2026

Udit-takkar added 2 commits February 5, 2026 15:22

chore: remove log

7207b56

chore: remove log

56284c2

Udit-takkar marked this pull request as ready for review February 5, 2026 10:18

graphite-app bot added the enterprise area: enterprise, audit log, organisation, SAML, SSO label Feb 5, 2026

graphite-app bot requested a review from a team February 5, 2026 10:18

Udit-takkar added this to the v6.2 milestone Feb 5, 2026

cubic-dev-ai bot reviewed Feb 5, 2026

View reviewed changes

packages/features/busyTimes/services/getBusyTimes.ts Show resolved Hide resolved

devin-ai-integration bot and others added 2 commits February 5, 2026 10:25

fix: avoid logging PII (userId) in busyTimes debug log

f8ba0c0

Replace JSON.stringify(busyTimes) with count to avoid exposing userId in logs. Addresses Cubic AI review feedback (confidence 9/10). Co-Authored-By: unknown <>

chore: undo

426928f

cubic-dev-ai bot reviewed Feb 5, 2026

View reviewed changes

packages/features/busyTimes/services/getBusyTimes.ts Show resolved Hide resolved

volnei approved these changes Feb 10, 2026

View reviewed changes

graphite-app bot added the ready-for-e2e label Feb 10, 2026

volnei enabled auto-merge (squash) February 10, 2026 15:44

volnei merged commit 3908cda into main Feb 10, 2026
90 of 91 checks passed

volnei deleted the devin/1769709003-optimize-busy-times-limit-checks branch February 10, 2026 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: optimize getBusyTimesForLimitChecks with batched parallel queries#27399

perf: optimize getBusyTimesForLimitChecks with batched parallel queries#27399
volnei merged 10 commits intomainfrom
devin/1769709003-optimize-busy-times-limit-checks

Udit-takkar commented Jan 29, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

devin-ai-integration bot commented Jan 29, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

paragon-review bot commented Feb 5, 2026

Updated Tests

Uh oh!

github-actions bot commented Feb 5, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

volnei left a comment

Uh oh!

volnei Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -351,10 +466,10 @@ export class BusyTimesService {
		status: BookingStatus.ACCEPTED,
		// FIXME: bookings that overlap on one side will never be counted

Conversation

Udit-takkar commented Jan 29, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Updates since last revision

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Human Review Checklist

Uh oh!

devin-ai-integration bot commented Jan 29, 2026

🤖 Devin AI Engineer

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2026

Devin AI is addressing Cubic AI's review feedback

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paragon-review bot commented Feb 5, 2026

Paragon: tests updated

Updated Tests

Uh oh!

github-actions bot commented Feb 5, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Devin AI is addressing Cubic AI's review feedback

Uh oh!

volnei left a comment

Choose a reason for hiding this comment

Uh oh!

volnei Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Udit-takkar commented Jan 29, 2026 •

edited by devin-ai-integration bot

Loading

github-actions bot commented Feb 5, 2026 •

edited by devin-ai-integration bot

Loading