feat: Add infrastructure for no-show audit integration by hariombalhara · Pull Request #27187 · calcom/cal.com

hariombalhara · 2026-01-23T11:11:42Z

What does this PR do?

Adds the infrastructure foundation for no-show audit integration. This is a preparatory PR that sets up the booking audit system to track no-show events. The actual integration with no-show flows will be stacked on top of this PR (PR #26570).

Key changes:

Database schema:

Adds SYSTEM source to BookingAuditSource enum for background jobs (tasker tasks, trigger.dev)
Consolidates HOST_NO_SHOW_UPDATED and ATTENDEE_NO_SHOW_UPDATED into single NO_SHOW_UPDATED action

New service:

NoShowUpdatedAuditActionService with array-based schema for attendees: attendeesNoShow: Array<{attendeeEmail, noShow}>
Deletes deprecated HostNoShowUpdatedAuditActionService and AttendeeNoShowUpdatedAuditActionService

Producer service updates:

BookingAuditProducerService.interface.ts: Replaces queueHostNoShowUpdatedAudit and queueAttendeeNoShowUpdatedAudit with unified queueNoShowUpdatedAudit
BookingAuditTaskerProducerService.ts: Implements the unified method
BookingEventHandlerService.ts: Replaces onHostNoShowUpdated and onAttendeeNoShowUpdated with unified onNoShowUpdated

Repository enhancements:

New AttendeeRepository methods for no-show queries (findByIds, findByBookingId, updateNoShow, findByBookingUidAndEmails, etc.)

UI updates:

BookingHistory component now supports values?: string[] in display fields for rendering multiple values
New DisplayFieldValue component for flexible field rendering

Type updates:

IBookingAuditRepository.BookingAuditAction updated to use NO_SHOW_UPDATED
ActionSourceSchema updated to include SYSTEM
BookingAuditActionSchema in bookingAuditTask.ts aligned with Prisma schema

Tests:

Integration tests for NoShowUpdatedAuditActionService covering host no-show, attendee no-show, and combined scenarios

Updates since last revision

Migration fix (addresses Cubic AI review feedback):

Fixed PostgreSQL error "unsafe use of new value of enum type" in 20260120093500_add_no_show_updated_audit_action/migration.sql
Removed the ADD VALUE statement that caused the transaction issue
Now uses a CASE expression in the ALTER TABLE ... USING clause to convert deprecated enum values (host_no_show_updated, attendee_no_show_updated) to the new unified value (no_show_updated) during the type conversion
This approach avoids the PostgreSQL limitation where new enum values cannot be used in the same transaction they were added

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - internal audit infrastructure only.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

This is infrastructure-only. Full testing will occur with the stacked integration PR (PR #26570).

Verify the migrations apply cleanly: yarn prisma migrate deploy
Verify type checking passes: yarn type-check:ci --force
Verify the NoShowUpdatedAuditActionService schema validates correctly
Run integration tests: VITEST_MODE=integration yarn test no-show-updated-action.integration-test.ts

Human Review Checklist

Migration safety: The migration now uses a CASE expression in the USING clause to convert deprecated enum values. Please verify the SQL syntax is correct.
Verify type consistency: BookingAuditAction is defined in multiple places (IBookingAuditRepository.ts, bookingAuditTask.ts, Prisma schema) - ensure they match
Verify NoShowUpdatedAuditActionService schema uses array format: attendeesNoShow: Array<{attendeeEmail, noShow}>
Verify IAuditActionService interface changes are backward compatible with existing action services (new values?: string[] field)
Verify BookingHistory component correctly renders the new values array field via DisplayFieldValue

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have checked if my changes generate no new warnings

- Add Prisma migrations for SYSTEM source and NO_SHOW_UPDATED audit action - Add NoShowUpdatedAuditActionService with array-based attendeesNoShow schema - Update BookingAuditActionServiceRegistry to include NO_SHOW_UPDATED - Update BookingAuditTaskConsumer and BookingAuditViewerService - Add AttendeeRepository methods for no-show queries - Update IAuditActionService interface with values array support - Update locales with no-show audit translation keys Co-Authored-By: [email protected] <[email protected]>

devin-ai-integration · 2026-01-23T11:11:46Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI' or '@devin'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

…urce types Co-Authored-By: [email protected] <[email protected]>

…okingAuditAction type to match Prisma schema Co-Authored-By: [email protected] <[email protected]>

…f HOST_NO_SHOW_UPDATED and ATTENDEE_NO_SHOW_UPDATED Co-Authored-By: [email protected] <[email protected]>

…wUpdatedAuditActionService - Delete HostNoShowUpdatedAuditActionService and AttendeeNoShowUpdatedAuditActionService - Update BookingAuditProducerService.interface.ts to use queueNoShowUpdatedAudit - Update BookingAuditTaskerProducerService.ts to use queueNoShowUpdatedAudit - Update BookingEventHandlerService.ts to use onNoShowUpdated - Add integration tests for NoShowUpdatedAuditActionService Co-Authored-By: [email protected] <[email protected]>

hariombalhara · 2026-01-23T12:54:06Z

packages/features/booking-audit/lib/actions/NoShowUpdatedAuditActionService.ts

Consolidated AttendeeNoShow and HostNoShow in this single action file because both host and attendee could update through a single action too.

cubic-dev-ai

1 issue found across 26 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/prisma/migrations/20260120093500_add_no_show_updated_audit_action/migration.sql">

<violation number="1" location="packages/prisma/migrations/20260120093500_add_no_show_updated_audit_action/migration.sql:28">
P1: Missing data migration step - this migration will fail if any existing records use the deprecated `host_no_show_updated` or `attendee_no_show_updated` enum values. Add an UPDATE statement before the type cast to convert existing data to the new `no_show_updated` value.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

packages/prisma/migrations/20260120093500_add_no_show_updated_audit_action/migration.sql

github-actions · 2026-01-23T12:59:32Z

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

Addresses Cubic AI review feedback (confidence 9/10): The migration now includes an UPDATE statement to convert existing records using the deprecated 'host_no_show_updated' or 'attendee_no_show_updated' enum values to the new unified 'no_show_updated' value before the type cast. This prevents migration failures if any existing data uses the old values. Co-Authored-By: unknown <>

hariombalhara · 2026-01-23T13:05:53Z

packages/prisma/migrations/20260120093500_add_no_show_updated_audit_action/migration.sql

BookingAudit table is empty in production at the moemnt, so we are safe to do destructive changes

Fixes PostgreSQL error 'unsafe use of new value of enum type' by avoiding the ADD VALUE statement and instead using a CASE expression in the ALTER TABLE USING clause to convert deprecated enum values (host_no_show_updated, attendee_no_show_updated) to the new unified value (no_show_updated) during the type conversion. Co-Authored-By: unknown <>

…udit

github-actions · 2026-01-27T14:29:59Z

E2E results are ready!

Workflow #101264.1 latest results

packages/features/booking-audit/lib/actions/NoShowUpdatedAuditActionService.ts

apps/web/modules/booking-audit/components/BookingHistory.tsx

packages/prisma/schema.prisma

Udit-takkar

Looks good. left few comments

Co-Authored-By: [email protected] <[email protected]>

devin-ai-integration

Devin Review found 1 potential issue.

View issue and 5 additional flags in Devin Review.

devin-ai-integration · 2026-01-29T11:18:50Z

apps/web/modules/booking-audit/components/BookingHistory.tsx

        const doesMatchDisplayFields = (): boolean => {
-            return log.displayFields?.some((field) => {
-                return field.valueKey?.toLowerCase().includes(searchTerm.toLowerCase()) ||
-                    field.labelKey?.toLowerCase().includes(searchTerm.toLowerCase());
-            }) ?? false;
+            return (
+                log.displayFields?.some((field) => {
+                    return (
+                        field.valueKey?.toLowerCase().includes(searchTerm.toLowerCase()) ||
+                        field.labelKey?.toLowerCase().includes(searchTerm.toLowerCase())
+                    );
+                }) ?? false
+            );


🟡 Search filter does not check value and values fields in displayFields

The search filter in useBookingLogsFilters only checks valueKey and labelKey when filtering audit logs, but the new displayFields type can also contain value and values properties.

Click to expand

Issue

The doesMatchDisplayFields function at lines 369-377 only checks:

field.valueKey?.toLowerCase().includes(searchTerm.toLowerCase()) || field.labelKey?.toLowerCase().includes(searchTerm.toLowerCase())

However, the NoShowUpdatedAuditActionService.getDisplayFields (NoShowUpdatedAuditActionService.ts:120-133) returns fields using value and values:

displayFields.push({ labelKey: "Attendees", values: attendeesFieldValues }); displayFields.push({ labelKey: "Host", value: hostFieldValue });

Impact

Users searching for attendee emails or host names in no-show audit logs will not find matching results, even though those values are displayed in the UI. The search functionality is incomplete for the new NO_SHOW_UPDATED audit action type.

Expected vs Actual

Expected: Searching for an attendee email like "[email protected]" should find no-show audit logs containing that attendee

Actual: The search returns no results because value and values fields are not checked

Recommendation: Update doesMatchDisplayFields to also check field.value and field.values:

const doesMatchDisplayFields = (): boolean => { return ( log.displayFields?.some((field) => { return ( field.valueKey?.toLowerCase().includes(searchTerm.toLowerCase()) || field.labelKey?.toLowerCase().includes(searchTerm.toLowerCase()) || field.value?.toLowerCase().includes(searchTerm.toLowerCase()) || field.values?.some(v => v.toLowerCase().includes(searchTerm.toLowerCase())) ); }) ?? false ); };

Was this helpful? React with 👍 or 👎 to provide feedback.

Fixing in a followup

packages/features/booking-audit/lib/actions/NoShowUpdatedAuditActionService.ts

pull-request-size bot added the size/XXL label Jan 23, 2026

github-actions bot added the ❗️ migrations contains migration files label Jan 23, 2026

devin-ai-integration bot mentioned this pull request Jan 23, 2026

chore: Integrate mark-no-show booking audit #26570

Merged

12 tasks

devin-ai-integration bot and others added 3 commits January 23, 2026 11:16

fix: Add NO_SHOW_UPDATED to BookingAuditAction and SYSTEM to ActionSo…

deca5ae

…urce types Co-Authored-By: [email protected] <[email protected]>

fix: Remove HOST_NO_SHOW_UPDATED and ATTENDEE_NO_SHOW_UPDATED from Bo…

acf128a

…okingAuditAction type to match Prisma schema Co-Authored-By: [email protected] <[email protected]>

fix: Update BookingAuditActionSchema to use NO_SHOW_UPDATED instead o…

24bd08e

…f HOST_NO_SHOW_UPDATED and ATTENDEE_NO_SHOW_UPDATED Co-Authored-By: [email protected] <[email protected]>

hariombalhara marked this pull request as ready for review January 23, 2026 11:47

hariombalhara requested a review from a team as a code owner January 23, 2026 11:47

graphite-app bot requested a review from a team January 23, 2026 11:47

graphite-app bot added enterprise area: enterprise, audit log, organisation, SAML, SSO core area: core, team members only labels Jan 23, 2026

hariombalhara added the ready-for-e2e label Jan 23, 2026

hariombalhara marked this pull request as draft January 23, 2026 11:53

hariombalhara commented Jan 23, 2026

View reviewed changes

hariombalhara marked this pull request as ready for review January 23, 2026 12:54

cubic-dev-ai bot reviewed Jan 23, 2026

View reviewed changes

packages/prisma/migrations/20260120093500_add_no_show_updated_audit_action/migration.sql Outdated Show resolved Hide resolved

hariombalhara commented Jan 23, 2026

View reviewed changes

devin-ai-integration bot and others added 2 commits January 23, 2026 13:12

Merge remote-tracking branch 'origin/main' into prepare-for-no-show-a…

d3d37cc

…udit

Merge branch 'main' into prepare-for-no-show-audit

a0f5bc2

Udit-takkar reviewed Jan 28, 2026

View reviewed changes

packages/features/booking-audit/lib/actions/NoShowUpdatedAuditActionService.ts Show resolved Hide resolved

Udit-takkar reviewed Jan 28, 2026

View reviewed changes

apps/web/modules/booking-audit/components/BookingHistory.tsx Outdated Show resolved Hide resolved

Udit-takkar reviewed Jan 28, 2026

View reviewed changes

packages/prisma/schema.prisma Show resolved Hide resolved

Udit-takkar reviewed Jan 28, 2026

View reviewed changes

devin-ai-integration bot and others added 2 commits January 29, 2026 05:11

fix: Replace hardcoded color with semantic text-success class

3b45217

Co-Authored-By: [email protected] <[email protected]>

fix: Remove color class completely from display fields

8fc490d

Co-Authored-By: [email protected] <[email protected]>

hariombalhara mentioned this pull request Jan 29, 2026

refactor(booking-audit): discriminated union for displayFields and i18n param support #27373

Merged

3 tasks

hariombalhara requested a review from Udit-takkar January 29, 2026 09:12

hariombalhara enabled auto-merge (squash) January 29, 2026 09:12

Udit-takkar approved these changes Jan 29, 2026

View reviewed changes

devin-ai-integration bot reviewed Jan 29, 2026

View reviewed changes

packages/features/booking-audit/lib/actions/NoShowUpdatedAuditActionService.ts Show resolved Hide resolved

hariombalhara mentioned this pull request Jan 29, 2026

fix: Update search filter to check value and values fields in displayFields #27386

Merged

5 tasks

volnei approved these changes Jan 29, 2026

View reviewed changes

hariombalhara merged commit 2802310 into main Jan 29, 2026
62 checks passed

hariombalhara deleted the prepare-for-no-show-audit branch January 29, 2026 11:47

Conversation

hariombalhara commented Jan 23, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Key changes:

Updates since last revision

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Human Review Checklist

Checklist

Link to Devin run

Link to Devin run (Cubic AI feedback)

Requested by

Uh oh!

devin-ai-integration bot commented Jan 23, 2026

🤖 Devin AI Engineer

Uh oh!

hariombalhara Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2026

Devin AI is addressing Cubic AI's review feedback

Uh oh!

hariombalhara Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 27, 2026

E2E results are ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Udit-takkar left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Jan 29, 2026

Choose a reason for hiding this comment

Issue

Impact

Expected vs Actual

Uh oh!

hariombalhara Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hariombalhara commented Jan 23, 2026 •

edited by devin-ai-integration bot

Loading