Skip to content

fix(examples): drop redundant subagents sidebar tray in canonical demo (post-#711 dedup)#722

Open
blove wants to merge 1 commit into
mainfrom
claude/examples-chat-subagent-dedup
Open

fix(examples): drop redundant subagents sidebar tray in canonical demo (post-#711 dedup)#722
blove wants to merge 1 commit into
mainfrom
claude/examples-chat-subagent-dedup

Conversation

@blove

@blove blove commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Found in a proactive consistency sweep after #711. The <chat> composition now renders each subagent inline as a persistent chat-subagent-card. But the canonical examples/chat demo-shell still mounted a separate active-only <chat-subagents> "Active subagents" sidebar tray — so during a research-subagent run the subagent showed in two places (inline card + sidebar tray).

This removes the redundant tray, matching the fix #718 already applied to cockpit/chat/subagents. Subagents now show once: inline + persistent.

Changes

  • demo-shell.component.html — removed the <chat-subagents> block.
  • demo-shell.component.ts — removed the now-unused ChatSubagentsComponent import + imports-array entry (subagentToolNames: ['research'] stays — it still drives the inline cards).
  • demo-shell.component.css — removed the orphaned .demo-shell__subagents rule.
  • cockpit/ag-ui/subagents — refreshed a stale doc comment ("renders a <chat-subagents> live card" → "renders each dispatch inline as a persistent chat-subagent-card").

Verification

  • examples-chat-angular lint + build — green.
  • examples-chat-angular e2e — green (research-subagent still asserts the inline chat-subagent-card; no e2e asserted on the removed tray).

A read-only sweep also confirmed the rest is clean: a2ui Material Symbols font is present in all 4 a2ui-rendering demos and no other surface renders a2ui icons; #705's welcome-copy pass is consistent across all 13+2 apps; and no other app double-displays subagents.

🤖 Generated with Claude Code

@blove
fix(examples): drop redundant <chat-subagents> sidebar tray in canoni…
4944f97 
…cal demo

After #711 the <chat> composition renders each subagent inline as a persistent
chat-subagent-card, so the demo-shell's separate active-only <chat-subagents>
sidebar tray double-displayed subagents during a run. Remove it (mount, import,
orphaned CSS) to match #718's fix for cockpit/chat/subagents. Also refresh a
stale comment in cockpit/ag-ui/subagents.
@vercel

vercel Bot commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadplane Ready Ready Preview, Comment Jun 20, 2026 3:31am

Request Review

github-actions[bot]
github-actions Bot approved these changes Jun 20, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@blove blove enabled auto-merge (squash) June 20, 2026 03:27
@github-actions

github-actions Bot commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 2m 32s —— View job

PR Review

  • Gather context and understand request
  • Read CLAUDE.md for repo guidelines
  • Review PR diff and changed files
  • Check for correctness bugs, type safety, Angular/RxJS pitfalls
  • Post findings

Verdict: LGTM. The removal is complete and consistent — all four touch-points are cleaned up together (TS import, imports array, HTML template, orphaned CSS rule). The subagentToolNames: ['research'] input on <chat> is correctly preserved, so inline card rendering is unaffected.

cockpit/ag-ui/subagents doc comment — updated wording accurately reflects post-#711 behaviour. No issues.

One minor observation (out of scope, FYI only): cockpit/chat/subagents/angular/src/app/subagents.component.ts still imports ChatSubagentCardComponent (line 6) but never uses it directly in its template — only <chat-subagents> appears there (line 55). That's a dead import, but it predates this PR and is a separate concern. The PR description references #718 as having already fixed cockpit/chat/subagents, so presumably that's tracked.

No bugs, no type-safety issues, no Angular/RxJS pitfalls, no public API regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@blove