Provide ares_nameser.h as a public interface#417
Merged
bradh352 merged 3 commits intoc-ares:mainfrom Aug 17, 2021
Merged
Conversation
Member
|
Contributor
Author
|
I have some trouble trying to understand the autotools part here. Do I need to write a dnl from scratch? Seems that I cannot test it too: |
Member
|
There is some issue going on with newer automake versions. Can you tell me what automake version you have? We have 2 issues on that #409 and #416. It would be useful if you could tell me what OS and version of the various tools you are running like those 2 tickets (actually, it would be useful to put the output in the ticket #416) to help isolate. |
Contributor
Author
|
It seems to be still broken - the generated ares_build.h still has While the files are present. |
…PAT_H in configure.ac
d1e8a75 to
5c02d58
Compare
Contributor
Author
|
Okay, I should have done it right this time. |
sergepetrenko
pushed a commit
to tarantool/c-ares
that referenced
this pull request
Jul 29, 2022
NodeJS needs ares_nameser.h as a pubic header. Fixes: c-ares#415 Fix By: Felix Yan (@felixonmars)
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Nov 19, 2023
It's not needed anymore: c-ares/c-ares#417
bell-sw
pushed a commit
to bell-sw/alpaquita-aports
that referenced
this pull request
Nov 23, 2023
[ commit a08daa58c1faa7ec69bb1aaf302f5e5570fe6ac8 ] It's not needed anymore: c-ares/c-ares#417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #415.