Fix last filename inconsistency on the cocktails index (#58) - #82
Merged
Merged
Conversation
The last remaining filename inconsistency the issue called out: the image was both misspelled (slighty) and truncated relative to the recipe's slug, slightly-sour-strawberry-smash. julip/julep was already fixed in #75.
Deploying britt-github-com with
|
| Latest commit: |
a21c97b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05b16f0a.britt-github-com.pages.dev |
| Branch Preview URL: | https://close-completed-issues.britt-github-com.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58
What #58 actually needed
The issue as originally filed proposed a card grid with hero images. It carries a correction (added when the design-system export landed, #40) ruling that out: the system's own words are "no cards … Shadows. None." — the cocktails index is a dated archive, not a card grid, and imagery belongs on the recipe pages (#59), not the index.
The corrected scope —
layouts/cocktails/list.htmlas aDatedList(.ds-dated/.ds-dated__row), reflowing across columns, keyboard-navigable rows, no images on the index — was already implemented and shipped in #75, with a follow-up grid fix in #80. This PR closes out the one item from #58 the correction explicitly left open:julip→julepwas fixed in #75.slighty-sour-strawberry.pngwas not — it's both a typo and truncated relative to its recipe's slug,slightly-sour-strawberry-smash.Change
static/img/cocktails/slighty-sour-strawberry.png→slightly-sour-strawberry-smash.pngcontent/cocktails/slightly-sour-strawberry-smash/index.mdNo template or CSS changes — the DatedList work is already done.
Verification
hugo --gc --minify --printPathWarnings --panicOnWarningpython3 scripts/check-links.py publicnode scripts/style-coverage.mjs publicnode scripts/token-coverage.mjs publictests/visual:npm test(scheme + axe a11y).ds-dated__titletests/visual:npm run test:responsiveslightly-sour-strawberry-smash_hu_*.webpemitted inpublic/Acceptance (as corrected by #40)
a11y.test.mjs, test 13)scheme.test.mjs, 24/24)🤖 Generated with Claude Code