Skip to content

Conversation

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Aug 10, 2025

Renamed PageView to BasePage throughout the codebase for clarity and consistency. Updated all imports, type hints, documentation, and test references to use BasePage, PageMediaData, and PageResizeEvent from the new module. Adjusted documentation and mkdocs navigation to reflect the change.

Close #5532

Summary by Sourcery

Rename PageView to BasePage for clarity and consistency and update all related references across the codebase.

Enhancements:

  • Rename the PageView class and its imports, all exports, and subclass relationships to BasePage
  • Update type hints and isinstance checks to use BasePage in base_control and control_event modules
  • Adjust flet.init to export BasePage instead of PageView

Documentation:

  • Rename and add documentation file controls/basepage.md and remove controls/pageview.md
  • Update mkdocs navigation to reference BasePage instead of PageView

Renamed PageView to BasePage throughout the codebase for clarity and consistency. Updated all imports, type hints, documentation, and test references to use BasePage, PageMediaData, and PageResizeEvent from the new module. Adjusted documentation and mkdocs navigation to reflect the change.

Close #5532
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@cloudflare-workers-and-pages
Copy link

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59e5bad
Status: ✅  Deploy successful!
Preview URL: https://3e82f6af.flet-docs.pages.dev
Branch Preview URL: https://v1-pageview-rename.flet-docs.pages.dev

View logs

@FeodorFitsner FeodorFitsner merged commit 35e2b8c into main Aug 10, 2025
3 of 4 checks passed
@FeodorFitsner FeodorFitsner deleted the v1-pageview-rename branch August 10, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1: Rename PageView to BasePage

3 participants