fix: set domain to (0, 1) when no data is present #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bqplot#1614 If no data is present, a scale has a domain of (0, 1) but if we remove the data (set it to an empty array) afterwards, we set it to (-inf, +inf) which causes rendering issues and make the bqplot figure unable to restore itself. It is more consistent to behave like no data was passed in, and use (0, 1) for the domain.
Member
Author
|
I hope i remembered the magic phrase correctly: By the power vested in me by all code repositories, I call upon the almighty 'update galata references' phoenix. Arise from the ashes of the old screenshots and blaze a trail of new visuals across our Github sky! |
Member
|
Looks like the phoenix burst into flames before it could try to fly. I suspsect the galata bot will only work with the main branch from now on. I guess since it's now using JupyterLab 4 and the new galata. |
Member
|
We need to upstream it to bqscales bqplot/bqscales#84 |
martinRenou
added a commit
to martinRenou/bqscales
that referenced
this pull request
Jul 27, 2023
martinRenou
added a commit
to bqplot/bqscales
that referenced
this pull request
Jul 27, 2023
martinRenou
added a commit
that referenced
this pull request
Jul 27, 2023
* fix: set domain to (0, 1) when no data is present Fixes #1614 If no data is present, a scale has a domain of (0, 1) but if we remove the data (set it to an empty array) afterwards, we set it to (-inf, +inf) which causes rendering issues and make the bqplot figure unable to restore itself. It is more consistent to behave like no data was passed in, and use (0, 1) for the domain. * Update snapshots * Require bqscales recent * Update Playwright Snapshots --------- Co-authored-by: Maarten A. Breddels <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
maartenbreddels
added a commit
to maartenbreddels/bqplot
that referenced
this pull request
Jan 30, 2024
In bqplot#1619 we reset the domain to (0, 1) when no data is present. However, this only matters when the min/max are not set.
maartenbreddels
added a commit
to maartenbreddels/bqplot
that referenced
this pull request
Jan 30, 2024
In bqplot#1619 we reset the domain to (0, 1) when no data is present. However, this only matters when the min/max are not set.
martinRenou
pushed a commit
that referenced
this pull request
Jan 30, 2024
* fix: domain should not be reset when min/max are set In #1619 we reset the domain to (0, 1) when no data is present. However, this only matters when the min/max are not set. * ci: pytest 8 make raises fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1614
If no data is present, a scale has a domain of (0, 1) but if we remove the data afterwards (set it to an empty array) , we set it to (-inf, +inf) which causes rendering issues and make the bqplot figure unable to restore itself.
It is more consistent to behave like no data was passed in, and use (0, 1) for the domain.