completed all problems - #26
Closed
the-d-j wants to merge 5 commits into
Closed
Conversation
sperrye
reviewed
Oct 24, 2017
| this.password = options.password; | ||
| } | ||
| comparePasswords(pwd) { | ||
| if (this.password === pwd) return true; |
There was a problem hiding this comment.
You can do this with one line return this.password === pwd
sperrye
reviewed
Oct 24, 2017
| // return the nth number in the sequence | ||
| if (n === 0) return 0; | ||
| if (n === 1) return 1; | ||
| if (n === 2) return 2; |
There was a problem hiding this comment.
The first number in your Fib sequence will be 1, not 0, so you can use if (n < 2) return 1 in place of 6 and 7. If n >= 2, then return nFibonacci(n - 1) + nFibonacci(n - 2);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by Don Utley