Need to modify the this.js for JSII and JSII-Mini. I'm practically do… - #204
Need to modify the this.js for JSII and JSII-Mini. I'm practically do…#204abrambueno1992 wants to merge 5 commits into
Conversation
…ne, but I need to modify and finish Part 2 of this.js for JSII. I'm a bit confused by part 2 of JSII, but I understand the concepts.
…otype.js and class.js.
frogr
left a comment
frogr
left a comment
There was a problem hiding this comment.
Hey Abraham. There's a lot of linter issues here! These all need to be cleaned up before you submit the assignment moving forward. I'm not able to run the tests until it's handled. I'd appreciate it if you could go back and fix this when you're free!
I'll go through and mark some issues with your code, but until the linting is fixed I can't officially test it with the lambda test suite. I'm confident that a lot of these errors would be fixed if you just went through and followed all the linting messages.
Your logic doesn't seem bad and I think you understand the material, but the linting absolutely needs to be fixed.
| constructor(options) { | ||
| this.username = options.username; | ||
| this.password = options.password; | ||
| this.checkPassword = (string) => { |
There was a problem hiding this comment.
checkPassword should be a method outside of the constructor, but still on the class.
| // do not modify this function's parameters | ||
| // note that we use the `function` keyword and not `=>` | ||
| console.log("Password: " +passwordToCompare); | ||
| if (this.password === passwordToCompare) return console.log("true and true"); |
There was a problem hiding this comment.
console.log for debugging purposes is fine, but here you have to return an actual boolean value
| this.dimensions = options.dimensions; | ||
| } | ||
| destroy() { | ||
| return `Game object was removed from the game.` |
There was a problem hiding this comment.
You should use " instead of ``` for strings that won't template data.
2 participants
…ne, but I need to modify and finish Part 2 of this.js for JSII. I'm a bit confused by part 2 of JSII, but I understand the concepts.