Skip to content

Kevin's JavaScript-II-Stretch-Assignment PR - #203

Open
ktan114 wants to merge 8 commits into
bloominstituteoftechnology:masterfrom
ktan114:master
Open

Kevin's JavaScript-II-Stretch-Assignment PR#203
ktan114 wants to merge 8 commits into
bloominstituteoftechnology:masterfrom
ktan114:master

Conversation

@ktan114

@ktan114 ktan114 commented Mar 21, 2018

Copy link
Copy Markdown

Had to delete previous PR with my commits due to not being able to push because of permission denied.

@frogr

frogr commented Mar 23, 2018

Copy link
Copy Markdown

Hey Kevin!

Looks like all of the tests are passing. Good job! There's no tests for it so I don't blame you, but you left off the very end of this.js. That'd be the call, apply, and bind methods at the bottom of the page. If you're confident you understand how to perform each of those methods, feel free to ignore this, but if you feel like you're not sure about it, then go ahead and go back and do that when you get some free time today.

Otherwise, this looks very good. I like the way you silenced the this error with the class destroy method :)

Good work Kevin!

@ktan114 ktan114 changed the title JS-II Kevin's JavaScript-II-Stretch-Assignment PR May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants