Skip to content

Justin Kaseman & Sumayyah - Complete - #168

Open
justinkaseman wants to merge 5 commits into
bloominstituteoftechnology:masterfrom
justinkaseman:master
Open

Justin Kaseman & Sumayyah - Complete#168
justinkaseman wants to merge 5 commits into
bloominstituteoftechnology:masterfrom
justinkaseman:master

Conversation

@justinkaseman

@justinkaseman justinkaseman commented Feb 23, 2018

Copy link
Copy Markdown
  • recursion.js
  • this.js
  • prototype.js
  • class.js
  • recursion.js stretch

@justinkaseman justinkaseman changed the title Justin Kaseman & Sumayyah - WIP Justin Kaseman & Sumayyah - Complete Feb 25, 2018
Comment thread src/class.js

// code here
class User {
constructor(options) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use object destructuring here:

  constructor({ email, password }) {
    this.email = email;
    this.password = password;
  }

Comment thread src/recursion.js
return n * nFactorial(n - 1);
};

// n < 2 works because both 1! and 0! return 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Comment thread src/recursion.js

// n < 2 works because both 1! and 0! return 1
/* Extra Credit */
const checkMatchingLeaves = (obj) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you guys would like me to go over the solution for checkMatchingLeaves, just send me a DM!

@frankfaustino

Copy link
Copy Markdown

Hi Justin and Sumayyah. Solid work here!

  • All tests are passing ✔️
  • Code is consistent with JS idioms and style ✔️
  • Demonstrated understanding of Classes, Prototype inheritance, this and recursion ✔️

Keep up the good work 🤘 (Please close this pull request after reviewing feedback)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants