Nick Kruger - JavaScript-II - #582
Open
NickKruger wants to merge 5 commits into
Open
Conversation
VivaCode
reviewed
Dec 5, 2018
|
|
||
| let averageDonationAmount = []; | ||
|
|
||
| averageDonationAmount = runners.reduce(function (total, tally) { |
There was a problem hiding this comment.
consider the extra code that isn't needed if you're not pushing into an empty array. test it, does the function still work?
| console.log(contains('Gum', items, match)); | ||
| console.log(contains('Hot Sauce', items, match)); | ||
| console.log(contains('yo-yo', items, match)); | ||
| console.log(contains('Apples', items, match)); |
| myName(); | ||
| // ==== Challenge 2: Create a counter function ==== | ||
| const counter = () => { | ||
| const counter = function () { |
There was a problem hiding this comment.
why did you change this from arrow function?
| }; | ||
| } | ||
|
|
||
| const newCounter = counter(); |
There was a problem hiding this comment.
what is the purpose of newCounter?
look into the difference between ++i and i++ - that may be helpful here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@VivaCode