Skip to content

Andrew Ogle - #501

Open
andrewogle wants to merge 6 commits into
bloominstituteoftechnology:masterfrom
andrewogle:master
Open

Andrew Ogle#501
andrewogle wants to merge 6 commits into
bloominstituteoftechnology:masterfrom
andrewogle:master

Conversation

@andrewogle

Copy link
Copy Markdown

I committed more than whats here but I tried to do a multi line comment and I think I did it wrong because I do not see me earlier commit messages.
@keirankozlowski

@keirankozlowski

Copy link
Copy Markdown

Objective

At the end of this module, you should be able to:

  • describe what closure is, how closure is created in a program and why it is important to have different types of scope
  • demonstrate the proper use a of a callback function by passing a function to another function as a parameter
  • demonstrate ability to use .map .reduce .filter and describe their use cases

MVP

Objectives

  • Array Methods MVP
  • Callbacks MVP
  • Closure MVP

Stretch

Goals

  • Callbacks stretch
  • Closure stretch
  • ES6 arrow syntax stretch

Great

  • Array Methods Challenge 1, nice use of template literals!
  • Array Methods nice job using the arrow syntax and dot chaining your functions!
  • Nice job using anon functions in your Callbacks assignment.
  • Good job with closures! This section looks solid.

Requests for Improvement

  • Don't forget to use the Format Document command prior to submission to clean up your code.
  • Please finish Array Methods Challenge 5!
  • For the Callbacks assignment with the "contains" function, using the forEach loop actually misses the mark here. You will return a value for each item, instead of returning true or false once depending on if the array contains the given element. Re-implement this as a simple for loop.
  • For your Closures assignment with the counter function, use return instead of console.log to give the newCount value. You could also use an increment operator (x++) instead of (x + 1), but your implementation works.

Commits

  • You're improving at commits, keep it up!

Rating: 1

I had to give you a 1 because the Array Methods Challenge 5 was incomplete; once you finish that, it'll be a 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants