Kelly Manahan - #48
Closed
kellymanahans wants to merge 3 commits into
Closed
Conversation
added 3 commits
April 17, 2018 16:56
nphillips78
reviewed
Apr 18, 2018
| }, 0); | ||
| console.log(ticketPriceTotal); | ||
|
|
||
|
|
nphillips78
reviewed
Apr 18, 2018
|
|
||
| // let myFunction = function () {}; | ||
| let myFunction =>{ | ||
| } |
There was a problem hiding this comment.
Don't forget that a function always has ().
nphillips78
reviewed
Apr 18, 2018
nphillips78
left a comment
nphillips78
left a comment
There was a problem hiding this comment.
Overall good work! Maybe spend some time looking at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Functions to get a better feel for function syntax.
nphillips78
reviewed
Apr 18, 2018
| } | ||
| emailFormat = emailFormat.push(item); | ||
| }); | ||
| console.log(wrongEmail) |
There was a problem hiding this comment.
Does this work for you when you run it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript II
Function Conversion
Convert the ES5 syntax into ES6 arrow syntax
Array Methods
Closures
Good Habits