Js -II Pull Request - #465
Conversation
|
Noah, yes, there are. However, I wouldn't worry about them for now as we aren't using pull requests for what they are intended to be used for (approving and merging changes). We're using them as an evaluative tool. You'll have opportunities to learn and practice PR best practice during Labs. |
TheBrockstar
left a comment
TheBrockstar
left a comment
There was a problem hiding this comment.
Objectives
With some basic JavaScript principles in hand, we can now expand our skills out even further by exploring callback functions, array methods, and closure. Finish each task in order as the concepts build on one another.
MVP
Task 1: Set Up The Project With Git
- Fork the project into your GitHub user account
- Clone the forked project into a directory on your machine
- You are now ready to build this project with your preferred IDE
- To test your
console.log()statements, open up the index.html file found in the assignments folder and use the developer tools to view the console.
Task 2: Callbacks
- Review the contents of the callbacks.js file. Notice you are given an array at the top of the page. Use that array to aid you with your callback functions.
- Write out each function using the
ES5functionkeyword syntax. - Solve the problems listed. Save the stretch problems until you have completed Tasks 1-4.
Task 3: Array Methods
- Review the contents of the array-methods.js file.
- Complete the problems provided to you
- Notice the last three problems are up to you to create and solve. This is an awesome opportunity for you to push your critical thinking about array methods, have fun with it.
Task 4: Closures
- Review the contents of the closure.js file.
- Solve the problems listed. Save the stretch problems until you have completed Tasks 1-4.
- Once you have completed this task please submit a pull request against the original fork.
Stretch
- Various Stretch Problems
Great
Dangit Noah. You did such a great job that I really had trouble finding feedback for you. You've done a great job on this.
Requests for Improvement
- Great improvement on commits. However, try adding a title and body next time.
Commits
Great improvement. Keep it up.
Rating: 3
| return x.email | ||
| }) | ||
| console.log(emails) | ||
| // Problem 2 |
There was a problem hiding this comment.
I am not sure what you mean. Did my sort or filter method not work?
| console.log(ticketPriceTotal); | ||
|
|
||
| // ==== Challenge 5: Be Creative ==== | ||
| // Now that you have used .forEach(), .map(), .filter(), and .reduce(). I want you to think of potential problems you could solve given the data set and the 5k fun run theme. Try to create and then solve 3 unique problems using one or many of the array methods listed above. |
There was a problem hiding this comment.
This is a great opportunity to practice using helpful comments. Your comments here could have told me, or any future user, what problems you decided to solve. This is a valuable skill as it makes your code readable for future developers (and for any manager/supervisor/Team Lead whose job it is to review your code).
There was a problem hiding this comment.
Thank you for the criticism. Now that you mention it I would have been ticked if I had run across this myself in the wild.
2 participants
@TheBrockstar Are there best practices for pull requests?