Trai Compton: PR Created - #451
Open
TraiLynne wants to merge 20 commits into
Open
Conversation
added 20 commits
October 16, 2018 13:59
szincone
reviewed
Oct 17, 2018
| @@ -5,44 +5,44 @@ With some basic JavaScript principles in hand, we can now expand our skills out | |||
|
|
|||
| let largeShirts = []; | ||
| let largeShirts = runners.filter((value) => { | ||
| return value.shirt_size == 'L'; | ||
| }) |
There was a problem hiding this comment.
I can't tell if you're using an autoformatter or not (an extension like Prettier), because you're missing the semicolon here and you use it at the end of the rest of your lines. If you're not using an autoformatter it could save you time, if you are using an autoformatter you can add the setting to your user settings to 'formatOnSave' and it will format every time you save it.
| function contains(item, list, cb) { | ||
| // contains checks if an item is present inside of the given array/list. | ||
| // Pass true to the callback if it is, otherwise pass false. | ||
| return cb(list.includes(item) ? true : false); |
There was a problem hiding this comment.
- Good use of your array methods (includes) and good use of ternary operator.
| // ==== Challenge 3: Use .filter() ==== | ||
| // The large shirts won't be available for the event due to an ordering issue. Get a list of runners with large sized shirts so they can choose a different size. Return an array named largeShirts that contains information about the runners that have a shirt size of L and log the result | ||
| let largeShirts = []; | ||
| let largeShirts = runners.filter((value) => { |
There was a problem hiding this comment.
Parentheses are optional when there's only one parameter name. (value) => { could be value => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.