Humberto Raya Javascript-II - #304
Open
hraya wants to merge 6 commits into
Open
Conversation
clarakosi
reviewed
Aug 22, 2018
| function firstItem(arr, cb) { | ||
| // firstItem passes the first item of the given array to the callback function. | ||
| for(let i = 0; i < arr.length; i++) { | ||
| if (arr[i] === arr[0]) { |
There was a problem hiding this comment.
Since i is starting at 0 arr[i] will be equivalent to arr[0]. The first element in the array will always be at arr[0]. So there was no need for this for loop. You could just pass arr[0] to the callback.
| last(items, lastItem) | ||
|
|
||
| function sumNums(x, y, cb) { | ||
| // sumNums adds two numbers (x, y) and passes the result to the callback. |
There was a problem hiding this comment.
Great solution but the function should have passed the sum to the callback. The same for the other 2 problems below it.
| return `I am ${nickname} from the states! and you?` | ||
| } | ||
|
|
||
| console.log(introduceSelf()); |
There was a problem hiding this comment.
Consider rewriting these with return instead of console.log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@clarakosi