Joseph Stossmeister: Main Finished - #125
Open
Jstoss wants to merge 6 commits into
Open
Conversation
Jstoss
commented
Jun 26, 2018
Jstoss
commented
- function-conversion completed
-Challenge 5, problem 2
-wanted to make sure I did the assignment as asked
EricHech
reviewed
Jun 27, 2018
| // ==== Challenge 4: Use .reduce() ==== | ||
| // The donations need to be tallied up and reported for tax purposes. Add up all the donations into a ticketPriceTotal array and log the result | ||
| let ticketPriceTotal = []; | ||
| let ticketPriceTotal = runners.reduce( (donation, runner) => donation += runner.donation, 0 ); |
There was a problem hiding this comment.
I don't see a need to set the starting val to 0 here, just a heads up.
Author
There was a problem hiding this comment.
I was having a weird bug that if I didn't set the starting value, it would freak out and return this long object value to the console. I meant to bring it up at the end of the day, but I completely forgot about it.
| console.log(theBusinesses); | ||
|
|
||
| // Problem 3 No newline at end of file | ||
| // Problem 3 |
There was a problem hiding this comment.
Awesome work in this file! Great creativity and commenting for your work.
For your filter, why not just do?:
runner => runner.company_name !== 'Photospace')
Author
There was a problem hiding this comment.
I'm going to be completely honest. It's been so long since I've had to or need to use !== that I completely forgot that it existed.
| @@ -1,19 +1,85 @@ | |||
| // ==== Challenge 1: Write your own closure ==== | |||
| // Write a simple closure of your own creation. Keep it simple! | |||
| let hundredWave = () => { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.