William DiFulvio [JavaScript-II] - #115
Open
Wdifulvio523 wants to merge 7 commits into
Open
Conversation
bdurb
reviewed
May 23, 2018
| // ==== Challenge 1: Use .forEach() ==== | ||
| // The event director needs both the first and last names of each runner for their running bibs. Combine both the first and last names into a new array called fullName. | ||
| let fullName = []; | ||
| runners.forEach(function(i) { |
There was a problem hiding this comment.
this is technically sound, however, i is often used to represent index, not the item. might confuse others down the road.
bdurb
reviewed
May 23, 2018
| // ==== Challenge 4: Use .reduce() ==== | ||
| // The donations need to be tallied up and reported for tax purposes. Add up all the donations into a ticketPriceTotal array and log the result | ||
| let ticketPriceTotal = []; | ||
| let ticketPriceTotal = runners.reduce((theReducer, item) => { |
bdurb
reviewed
May 23, 2018
| if (list[i] === item) { | ||
| cb(true) | ||
| } | ||
| } cb(false); |
There was a problem hiding this comment.
best practices would have you put the cb(false) on the next line after the curly brace. but still technically sound.
|
@Wdifulvio523 thank you for the PR. Great job today. I pointed out a few things that while technically sound, might not fit in with best practices. but all in all great work! |
… on the line after curly braces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.