JS 1 - #41
Closed
BonnW wants to merge 1 commit into
Closed
Conversation
sperrye
reviewed
Oct 13, 2017
| // `startingValue` is the starting value. If `startingValue` is undefined then make `elements[0]` the initial value. | ||
| let memo; | ||
| if (startingValue) { | ||
| memo = cb(startingValue, elements[0]); |
There was a problem hiding this comment.
Pass elements to the cb in your for loop
sperrye
reviewed
Oct 13, 2017
| const newArr = []; | ||
| Object.keys(obj).forEach((key, value) => { | ||
| newArr[value] = key; | ||
| }); |
There was a problem hiding this comment.
Object.keys(obj) returns an array of all the keys as strings. You don't have to do anything else.
sperrye
reviewed
Oct 13, 2017
| // http://underscorejs.org/#values | ||
| const newArr = []; | ||
| Object.keys(obj).forEach((key, value) => { | ||
| newArr[value] = obj[key]; |
There was a problem hiding this comment.
You may already be aware of this, but just to clarify: when you use .forEach((key, value)) what you're really passing to the function is the key and the index of the key in the Object.keys array. As is, this function is passing values to newArr, but it's because you're assigning the values with obj[key] at newArr[index]. obj[key] points to that key's value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.