JavaScript-I - homework - #10
Closed
lightofdavinci wants to merge 2 commits into
Closed
Conversation
added 2 commits
October 3, 2017 18:44
Author
|
I was in a hurry and afraid of using the forEach method in Object.js file because of a warning I read in comments. Here is a more elegant example that shows my understanding of how forEach works. |
sperrye
reviewed
Oct 17, 2017
| // code here | ||
|
|
||
| const contains = (arr,item,cb) => { | ||
| arr.indexOf(item) !== -1 ? cb(true) : cb(false); |
sperrye
reviewed
Oct 17, 2017
| // newCounter(); // 2 | ||
| let x = 0; | ||
| return () => { | ||
| return x += 1; |
sperrye
reviewed
Oct 17, 2017
| const result = []; | ||
| const props = Object.keys(obj); | ||
| for (let i = 0, leng = props.length; i < leng; i++) { | ||
| if (typeof props[i] !== 'function') { |
There was a problem hiding this comment.
Why are you testing typeof for function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.