Skip to content

JS 1 - #542

Open
Abott1222 wants to merge 7 commits into
bloominstituteoftechnology:masterfrom
Abott1222:master
Open

JS 1#542
Abott1222 wants to merge 7 commits into
bloominstituteoftechnology:masterfrom
Abott1222:master

Conversation

@Abott1222

Copy link
Copy Markdown

Comment thread assignments/arrays.js Outdated
*/

console.log('es6 challenge 1');
let car33 = x.find( (object, ix) => object.id === 33 );

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: x is not defined

Comment thread assignments/arrays.js Outdated
return car.car_make === "BMW" || car.car_make === "Audi"
})
console.log('es6 challenge 6');
for(let car of BMWAndAudiES6) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SyntaxError: Identifier 'BMWAndAudiES6' has already been declared (135:4)​​

@clintKunz

Copy link
Copy Markdown

MVP

  • Complete Object challenges without any errors
  • Complete Array challenges without any errors
  • Don’t use map, reduce, or filter

Stretch

  • Arrow function syntax
  • Review callback material for tomorrow
  • Use array methods on the array’s assignment

What Looks Great

  • MVP and most of Stretch complete! Nice work
  • Frequent and descriptive commits
  • Code is well formatted and easy to read
  • Great file structure

What Could Be Improved

  • A few stretch errors

What Could Be Added

Rating (1-3)

3

@Abott1222

Copy link
Copy Markdown
Author

@clintKunz Thanks! Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants