Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36185. ReviewsSee the guideline and AI policy for information on the review process. |
fametrano
force-pushed
the
test-bip32-vectors
branch
2 times, most recently
from
September 16, 2026 06:51
11e2867 to
373a881
Compare
test_bip32_vectors covers vectors 1 and 2 only. Add vectors 3 and 4 from BIP32, which exercise retention of leading zeros in a private key and hardened derivation over such a key. Both run against the existing API.
fametrano
force-pushed
the
test-bip32-vectors
branch
from
September 18, 2026 20:55
373a881 to
6fa4c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_bip32_vectorscovers BIP32 vectors 1 and 2 only. Vectors 3 and 4 test retention of leading zeros in a private key and hardened derivation over such a key — the cases implementations have historically got wrong.Both run against the existing API; no new capability is needed.