Conversation
Contributor
Author
|
Putting this on hold until we have some discussion in developer relations because @chasenlehara has asked me to do some research on the possibility of using eslint or prettier, instead of jshint. |
This was referenced Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@justinbmeyer Would like your go-ahead before fixing these
jshinterrors:jshintsettings?siteConfig["static"]tositeConfig.static?I know this isn't a high priority item, but think it's something that should be done sooner than later (before there's popularity and a bunch of PRs that will need to be restructured themselves).
This will be a sweeping change to many files, so ideally should be done all at once.
This is something I would like to do for all bit-docs repos; as an example, I've created a jshint branch for bit-docs-generate-html as well:
https://github.com/bit-docs/bit-docs-generate-html/tree/jshint
EDIT — I noticed
bit-docs-process-mustacheis one that already contain a.jshintrc:https://github.com/bit-docs/bit-docs-process-mustache/blob/master/.jshintrc