Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

NikitK/ binary.com - Options for Branding Removal #7274

Merged
matin-deriv merged 10 commits into
binary-com:masterfrom
NikitK-deriv:pr-58847-nikitk-binary-branding-removal
Mar 6, 2023
Merged

NikitK/ binary.com - Options for Branding Removal #7274
matin-deriv merged 10 commits into
binary-com:masterfrom
NikitK-deriv:pr-58847-nikitk-binary-branding-removal

Conversation

@NikitK-deriv

Copy link
Copy Markdown
Contributor

branding removal exclude binary and localhost domain

@vercel

vercel Bot commented Oct 20, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
binary-static ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 3:52AM (UTC)

@github-actions

github-actions Bot commented Oct 20, 2022

Copy link
Copy Markdown

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/binary-static/pull/7274](https://github.com/binary-com/binary-static/pull/7274)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-nikitk-deriv-pr-58847-nikitk-bina-257ea9.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=27993
    - **Original**: https://binary-static-git-fork-nikitk-deriv-pr-58847-nikitk-bina-257ea9.binary.sx/en/logged_inws.html
- **App ID**: `27993`

@akmal-deriv akmal-deriv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nikita👋🏻, I think there's some slight misunderstanding regarding this task. We want to create a configuration file which can be used to set/alter the branding and logos across the entire binary website. In this PR you are just creating a classname which can be used to remove it. You can refer to our deriv-app implementation for the similar card here: deriv-com/deriv-app#5439 .

@NikitK-deriv

Copy link
Copy Markdown
Contributor Author

Hi Nikita👋🏻, I think there's some slight misunderstanding regarding this task. We want to create a configuration file which can be used to set/alter the branding and logos across the entire binary website. In this PR you are just creating a classname which can be used to remove it. You can refer to our deriv-app implementation for the similar card here: binary-com/deriv-app#5439 .

Hi Akmal,
Actually I prefer your solution. But compliance team requested just to entirely hide logo and footer for deriv.com and binary.com 😞

yashim-deriv
yashim-deriv previously approved these changes Oct 20, 2022
@sonarqubecloud

sonarqubecloud Bot commented Nov 1, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants