fix: resolve 400 Bad Request on tool calls with null content - #1
Open
andomeder wants to merge 2 commits into
Open
fix: resolve 400 Bad Request on tool calls with null content#1andomeder wants to merge 2 commits into
andomeder wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where models generating tool calls (like
xiaomi/mimo-v2.5-pro) sendcontent: nullwhile thinking/acting.Previously, the proxy passed this
nilvalue through, causing the JSON marshaler to outputnull. CommandCode's API strictly expects an array or string, resulting in a400 Bad Request: expected array, received null.Changes Made
BuildCCRequestWithWorkingDirininternal/proxy/proxy.go.[]api.CCContentPart{}when the incoming message content isnil.This ensures the JSON marshaler outputs an empty array
[]instead ofnull, satisfying the upstream schema validation while preserving the tool call data.