lib: fix lib/internal/blob.js Blob.stream() for nodejs#48668 nodejs#48916

bellbind · bellbind · commit b7d9941036ba · 2023-07-27T08:14:42.000+09:00
Add lacked calling resolve() for finish ReadableStream source.pull(). Fixes: nodejs#48668 Fixes: nodejs#48916 Fixes: nodejs#48232 Refs: 8cc1438
diff --git a/lib/internal/blob.js b/lib/internal/blob.js
@@ -361,7 +361,7 @@ class Blob {
               if (c.desiredSize <= 0) {
                 // A manual backpressure check.
                 if (this.pendingPulls.length !== 0) {
-                  // case of waiting pull finished (= not yet canceled)
+                  // A case of waiting pull finished (= not yet canceled)
                   const pending = this.pendingPulls.shift();
                   pending.resolve();
                 }
diff --git a/test/parallel/test-blob.js b/test/parallel/test-blob.js
@@ -270,16 +270,16 @@ assert.throws(() => new Blob({}), {
 })().then(common.mustCall());
 
 (async () => {
-  const b = new Blob(["A", "B", "C"]);
+  const b = new Blob(['A', 'B', 'C']);
   const stream = b.stream();
   const chunks = [];
   const decoder = new TextDecoder();
   await stream.pipeTo(new WritableStream({
     write(chunk) {
-      chunks.push(decoder.decode(chunk, {stream: true}));
+      chunks.push(decoder.decode(chunk, { stream: true }));
     }
   }));
-  assert.strictEqual(chunks.join(""), "ABC");
+  assert.strictEqual(chunks.join(''), 'ABC');
 })().then(common.mustCall());
 
 (async () => {

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ class Blob {`
`361`	`361`	`if (c.desiredSize <= 0) {`
`362`	`362`	`// A manual backpressure check.`
`363`	`363`	`if (this.pendingPulls.length !== 0) {`
`364`		`- // case of waiting pull finished (= not yet canceled)`
	`364`	`+ // A case of waiting pull finished (= not yet canceled)`
`365`	`365`	`const pending = this.pendingPulls.shift();`
`366`	`366`	`pending.resolve();`
`367`	`367`	`}`