Open
Conversation
Contributor
|
Cool. I didn't even realise pip had an option to do this! |
Contributor
Author
I don't think that would do anything at present, since the workflow doesn't actually run pytest, or even install the package. It also appears that the CI action has not run for 2 years at this point - probably that maintenance should happen in a separate PR. |
Contributor
|
Fair enough. I managed to get the tests running on my fork, but never really dug into what they were actually doing. |
putuhs01
approved these changes
Feb 3, 2025
putuhs01
approved these changes
Feb 3, 2025
snejus
approved these changes
May 18, 2025
Member
snejus
left a comment
snejus
left a comment
There was a problem hiding this comment.
Is this still relevant? This looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
This PR is similar to #145, but implements the alternative strategy described in #144 of making deprecated dependencies optional on python 3.13.
This isn't necessarily meant to supersede #145, just to provide an alternative implementation that's ready to go in case @sampsyo wants to go this route instead.
Summary of changes:
audioop-ltsas a hard requirement onpython >= 3.13. This is necessary for thelin2linfunction used in all rawread paths.legacymode installation which includes dependencies forstandard-aifcandstandard-sunauifpython >= 3.13. Can be invoked bypython -m pip install audioread[legacy].