Skip to content
Open
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
e0222af
OpenPGP Smart Card Support: Add support for message signing
vanitasvitae Sep 8, 2026
5e613d2
Reuse parseEphemeralKeyAndKeyEnc methods
vanitasvitae Sep 8, 2026
42bbca6
Direct conversion of JCE ECDH key without PGPPublicKey workaround
vanitasvitae Sep 8, 2026
d55fcc9
B1 - move PGPContentSignerBuilderProviderFactory into openpgp/api/ope…
vanitasvitae Sep 10, 2026
f339de7
B2 - Move build(sigType) into PGPExternalContentSignerBuilder to avoi…
vanitasvitae Sep 10, 2026
3b8cf61
Conventions: Curly Brackets
vanitasvitae Sep 10, 2026
2a87e19
Conventions: Wildcard imports
vanitasvitae Sep 10, 2026
dd2af32
Conventions: Uncommented code
vanitasvitae Sep 10, 2026
50eb8cb
Conventions: Readme with newline
vanitasvitae Sep 10, 2026
a8eb7c5
Conventions: Suppress println statement
vanitasvitae Sep 10, 2026
8e3fe9c
Conventions C6: Bring exceptions of decrypt/sign in line
vanitasvitae Sep 10, 2026
e89c278
ExternalContentSignerBuilder: Explain why we need two PGPDigestCalcul…
vanitasvitae Sep 10, 2026
6eff13a
ExternalContentSignerBuilder: Replace use of pqc DigestUtils with Mes…
vanitasvitae Sep 10, 2026
bef5f29
Reduce visibility of BcPublicKeyDataDecryptorFactory.decodePeerKey()
vanitasvitae Sep 10, 2026
3732edc
B3 - Fix NPE when no card holds the signing key
vanitasvitae Sep 10, 2026
dafad9b
B4 - BcPublicKeyDataDecryptorFactory: Throw PGPException for unsuppor…
vanitasvitae Sep 10, 2026
aba2fc8
B5 - fix off-by-one in shortened legacy identifier check
vanitasvitae Sep 10, 2026
bf6cedb
B5 - Add test for off-by-one error
vanitasvitae Sep 10, 2026
139199d
B6 - SupportedAlgorithms: Fix IllegalArgumentException for EC.matches…
vanitasvitae Sep 10, 2026
5df3c4d
B7 - Fix StringIndexOutOfBoundsException on toString() if SupportedAl…
vanitasvitae Sep 10, 2026
01bdbc6
B8 - OpenPGPSmartCardBackend: Do not shadow the converter in subclasses
vanitasvitae Sep 10, 2026
049daae
B9 - Shortened legacy fingerprints: Make identifier writer and matche…
vanitasvitae Sep 10, 2026
a2f1ba1
D1 - Replace BCECPublicKeyHelper, EDECPublicKeyConverter with KeyFact…
vanitasvitae Sep 10, 2026
057aa82
D2 - JceExternalPublicKeyDataDecryptorFactoryBuilder: Use helper.crea…
vanitasvitae Sep 10, 2026
cb86392
F1: openpgp.operator: Remove dependency on openpgp.api
vanitasvitae Sep 17, 2026
513bb96
F2: Do not throw unchecked PGPRuntimeOperationException during decrypt
vanitasvitae Sep 17, 2026
8e10966
F3: Implement proper OpenPGP digest OID lookup
vanitasvitae Sep 17, 2026
fb34495
F4: Fix signing with auth key PIN verification
vanitasvitae Sep 17, 2026
9af38e5
OpenPGPMessageProcessor: Add .setExceptionCallback()
vanitasvitae Sep 17, 2026
4e5a6fc
DecryptionTest: printStacktrace() exceptions
vanitasvitae Sep 17, 2026
ed06faa
F9: OpenPGPSmartCardBackend.convertPublicKey(): Detect algorithm by OID
vanitasvitae Sep 17, 2026
5973461
Add branches for Ed448, X448
vanitasvitae Sep 17, 2026
2b1b53f
Generalize convertPublicKey() methods
vanitasvitae Sep 17, 2026
d210c3c
SimulatorOpenPGPSmartCardBackend: Initialize with non-null JcaPGPKeyC…
vanitasvitae Sep 17, 2026
e9c0f90
Transform YubikeySmartCardBackendTest into general OpenPGPSmartCardBa…
vanitasvitae Sep 17, 2026
8a7be67
Reorganize tests
vanitasvitae Sep 17, 2026
660c41c
F10: SimulatorOpenPGPSmartCard: Use PublicKeyFactory.createKey(byte[]…
vanitasvitae Sep 17, 2026
fa2461c
Add missing package-info.java files
vanitasvitae Sep 17, 2026
3dc8e52
ExternalOpenPGPKeyUtils.fromCertificate(): Pass in implementation
vanitasvitae Sep 17, 2026
8c6d4ad
F6: Properly handle failing backends, add test for failing signature,…
vanitasvitae Sep 17, 2026
ef66b06
F7: BcPublicKeyDataDecryptorFactory: Add deprecated shim for getCrypt…
vanitasvitae Sep 17, 2026
9d5dba2
Remove notice about ElGamal, X448 from BcSmartCardPublicKeyDataDecryp…
vanitasvitae Sep 17, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
B6 - SupportedAlgorithms: Fix IllegalArgumentException for EC.matches…
…(nonEcKey)
  • Loading branch information
vanitasvitae committed Sep 10, 2026
commit 139199d9bf325f3bc1cc6d52143e4bff5d39a2f5
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,12 @@ public boolean matches(int keyAlgorithm, ASN1ObjectIdentifier keyCurve)
public boolean matches(OpenPGPCertificate.OpenPGPComponentKey key)
{
ASN1ObjectIdentifier keyCurve = getKeyCurveOID(key);
int keyAlgorithm = key.getAlgorithm();
if (keyCurve == null)
{
return false; // unknown key curve
}

int keyAlgorithm = key.getAlgorithm();
return matches(keyAlgorithm, keyCurve);
}

Expand All @@ -212,7 +216,7 @@ else if (pubKey instanceof Ed25519PublicBCPGKey)
{
return EdECObjectIdentifiers.id_Ed25519;
}
throw new IllegalArgumentException("unknown key type: " + pubKey.getClass().getName());
return null;
}

@Override
Expand Down