Allow specifying message format as an argument #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaind
commented
Sep 21, 2025
| MessageFormat::Json | ||
| } | ||
| "json-render-diagnostics" => MessageFormat::Other, | ||
| _ => MessageFormat::NotSet, |
Author
There was a problem hiding this comment.
Is this ok? Or should it be other?
blaind
commented
Sep 21, 2025
|
|
||
| /// The output format for cargo messages. | ||
| #[derive(Debug, PartialEq)] | ||
| pub enum MessageFormat { |
Author
There was a problem hiding this comment.
The namings for enum values could be better
Owner
|
This would interfere with the message handling already implemented to determine what the output dependencies are, so requires more thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using cargo-ndk as a rust-analyzer.check.overrideCommand in vscode.
As follows
Currently, if the command would see any errors, the output would be captured and printed human-style.
This merge request checks, if user has overridden the message format. The printout is also selected to be json or formatted, depending on the argument. Based on list at https://doc.rust-lang.org/cargo/commands/cargo-check.html#display-options