build: Support arm64 container and add containerized build target#136
Merged
pingleig merged 4 commits intoaws:masterfrom Dec 18, 2020
Merged
build: Support arm64 container and add containerized build target#136pingleig merged 4 commits intoaws:masterfrom
pingleig merged 4 commits intoaws:masterfrom
Conversation
* For aws#114 user no longer need to write their own Dockerfile and it works with `docker buildx` * Add containerized build for developer w/o a local go environment
pxaws
reviewed
Dec 18, 2020
amazon-cloudwatch-container-insights/cloudwatch-agent-dockerfile/README.md
Outdated
Show resolved
Hide resolved
pxaws
reviewed
Dec 18, 2020
amazon-cloudwatch-container-insights/cloudwatch-agent-dockerfile/README.md
Outdated
Show resolved
Hide resolved
amazon-cloudwatch-container-insights/cloudwatch-agent-dockerfile/README.md
Outdated
Show resolved
Hide resolved
amazon-cloudwatch-container-insights/cloudwatch-agent-dockerfile/README.md
Outdated
Show resolved
Hide resolved
pxaws
approved these changes
Dec 18, 2020
sky333999
pushed a commit
that referenced
this pull request
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
The Dockerfile is hard coded to use amd64 binary, we should determine it at runtime or let build context specify it.
Description of changes
TARGETARCHarg fromdocker buildxor fallback todpkg --print-architectureLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
For multi arch build, make sure you have docker buildx, you need to use the edge version instead of the stable one.