Skip to content

Fix install for non-admin users #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadovnychyi merged 1 commit into from
Aug 21, 2018
Merged

Fix install for non-admin users #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/main.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,17 @@ module.exports =
atom.config.set('autocomplete-python.useKite', installed)
)

installer.on('not-admin-shown', () ->
# Show installation again if user restarts as admin. There is a
# separate user option to explicitly not show this again.
installed = true
)

installer.on('not-admin-dismissed', () ->
installed = false
atom.config.set('autocomplete-python.useKite', installed)
)

installer.start()
, (err) =>
if typeof err != 'undefined' and err.type == 'denied'
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"atom-slick": "^2.0.0",
"atom-space-pen-views": "~2.1.0",
"fuzzaldrin-plus": "^0.3.1",
"kite-installer": "^2.0.5",
"kite-installer": "^2.0.7",
"selector-kit": "^0.1",
"space-pen": "^5.1.2",
"underscore": "^1.8.3",
Expand Down