feat: add help message about AnonymousSchema generated classes#211
Merged
asyncapi-bot merged 8 commits intoasyncapi:masterfrom Jul 18, 2022
Merged
feat: add help message about AnonymousSchema generated classes#211asyncapi-bot merged 8 commits intoasyncapi:masterfrom
asyncapi-bot merged 8 commits intoasyncapi:masterfrom
Conversation
derberg
requested changes
Mar 28, 2022
Member
derberg
left a comment
There was a problem hiding this comment.
- using template literals would be better/easier imho to build these structured console log information.
- would be super nice to point user in some direction that will help figure out where things happened. Maybe at least consol.log paths to files with anonymous schema name models?
Member
Author
Paths were added. |
Member
|
@Tenischev one example of template literal: most of these console.log you could put in one literal, which would make it much easier to maintain |
derberg
reviewed
Jun 7, 2022
use one string for help message Co-authored-by: Lukasz Gornicki <[email protected]>
Member
|
I think you need to update tests |
Member
Author
seems to be a bug of build |
derberg
approved these changes
Jun 13, 2022
Member
|
@Tenischev just keep in mind that if it is |
Member
|
/rtm |
Contributor
|
🎉 This PR is included in version 0.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many times users faced problem with
AnonymousSchemamodel classes. This happens because someschemaselement defined as sub-object (insideallOf,itemse.t.c.) and parser couldn't provide any significant name for them and so class name couldn't be defined.This behavior is not directly problem of parser or template, but rather of user's AsyncAPI itself.
So, I decided to add info message with description how to discard
AnonymousSchemaclasses if generation result contains them.Related issue(s)
See also #203 #131 #78