feat: add support for security schemes in Kafka config#158
Merged
derberg merged 3 commits intoasyncapi:masterfrom Oct 28, 2021
Merged
feat: add support for security schemes in Kafka config#158derberg merged 3 commits intoasyncapi:masterfrom
derberg merged 3 commits intoasyncapi:masterfrom
Conversation
This commit adds support for the new security schemes introduced in AsyncAPI 2.1.0, for code generated for Kafka servers. When provided with AsyncAPI specification documents that describe Kafka clusters requiring authentication, the generator will now be able to generate the correct configuration for client code. Signed-off-by: Dale Lane <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Member
|
@Tenischev hey man, have time for a review? @dalelane thanks! let's wait for @Tenischev and if there is no response in few days we will just approve and merge this PR. I know that @Tenischev is not round for some time already but let us make sure for the last time |
derberg
approved these changes
Oct 28, 2021
Contributor
|
🎉 This PR is included in version 0.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for the new security schemes introduced
in AsyncAPI 2.1.0, for code generated for Kafka servers.
When provided with AsyncAPI specification documents that describe
Kafka clusters requiring authentication, the generator will now
be able to generate the correct configuration for client code.
I'm not familiar with Spring, so I'm absolutely open to suggestions
about whether the structure for these changes is appropriate.
Signed-off-by: Dale Lane [email protected]