feat: set ADD_TYPE_INFO_HEADERS to true and control it with new addTypeInfoHeader param#138
Conversation
…aders to be added to the message header.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
This is my first PR, So I hope I am doing everything right 😄 |
|
@amrutprabhu looks good, according to docs default is true. But because it was |
|
Hey @derberg , I made the appropriate change. I let the default value be true. But if anyone wants to set it to false, can set the param Can you verify this ? |
derberg
changed the title
derberg
changed the title
|
@amrutprabhu I took liberty to adjust the PR title because this is not a bug fix but a new feature, new parameter. This way we will automatically trigger minor and not patch release |
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
cool.. |
|
@all-contributors please add @amrutprabhu for code |
|
I've put up a pull request to add @amrutprabhu! 🎉 |
3 participants
This sets the property of adding
ADD_TYPE_INFO_HEADERSto true for Kafka.Currently, it is set to false, Causing the producer to not add headers, and then the corresponding consumer is not able to do the type conversion.
the property being false, cause the next property i.e
of no use, as it's not able to add the headers.
Related issue(s)
This fixes the first part of the issue: #137
Resolves #137