fix: remove \ from \\ in regex patterns for @Pattern annotation#134
Merged
derberg merged 2 commits intoasyncapi:masterfrom Jun 17, 2021
Merged
fix: remove \ from \\ in regex patterns for @Pattern annotation#134derberg merged 2 commits intoasyncapi:masterfrom
derberg merged 2 commits intoasyncapi:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
tuxBurner
changed the title
Member
|
LGTM, can you please fix the PR title @tuxBurner |
tuxBurner
changed the title
tuxBurner
changed the title
Contributor
Author
Okay i hope this is okay now :) |
derberg
changed the title
Member
|
@tuxBurner changed a bit, I hope you don't mind |
derberg
approved these changes
Jun 17, 2021
Contributor
|
🎉 This PR is included in version 0.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when having a regex with \ in pattern the openapi removes it from it.
For example having in the yaml:
will result in the java code to:
but should be:
Related issue(s)
Resolves #122