feat(tracking): impression tracking for home sections#17200
Open
nickskalkin wants to merge 1 commit into
Open
Conversation
nickskalkin
force-pushed
the
nickskalkin/home-page-rail-impression-tracking
branch
from
37e5ac9 to
24c3b9d
Compare
#8231 Bundle Size — 8.73MiB (-0.69%).8e3109b(current) vs 206868a main#8227(baseline) Warning Bundle contains 29 duplicate packages – View duplicate packages Warning Bundle introduced 2 new packages: superagent, component-emitter – View changed packages Bundle metrics
|
| Current #8231 |
Baseline #8227 |
|
|---|---|---|
 Initial JS |
2.88MiB(-0.49%) |
2.89MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
66.79% |
15.82% |
| Chunks |
110(-0.9%) |
111 |
| Assets |
113(-0.88%) |
114 |
| Modules |
5571(-0.61%) |
5605 |
| Duplicate Modules |
630(-3.67%) |
654 |
| Duplicate Code |
4.83%(-2.82%) |
4.97% |
 Packages |
250(+0.81%) |
248 |
| Duplicate Packages |
28 |
28 |
Bundle size by type 
2 changes 
2 improvements
| Current #8231 |
Baseline #8227 |
|
|---|---|---|
| JS |
8.58MiB (-0.68%) |
8.64MiB |
| Other |
152.85KiB (-1.08%) |
154.53KiB |
Bundle analysis report Branch nickskalkin/home-page-rail-impre... Project dashboard
Generated by RelativeCI Documentation Report issue
nickskalkin
force-pushed
the
nickskalkin/home-page-rail-impression-tracking
branch
from
24c3b9d to
8e3109b
Compare
nickskalkin
force-pushed
the
nickskalkin/home-page-rail-impression-tracking
branch
from
393f211 to
8e3109b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
This PR solves ONYX-1859
Description
Adds Cohesion RailViewed impression events for every section on the home feed (plus MyBids). An event fires once per mount after the rail stays sufficiently visible for ~1 second, so we capture genuine impressions instead of scroll-by glances.
Update: opened #17206 for item impressions tracking (builds on top of the current PR)