Skip to content

Conversation

@jinyongyoo
Copy link
Collaborator

What does this PR do?

Update Pytorch version requirement to be above 1.7.0 but skip 1.8.0

Summary

Previously, we had to limit Pytorch to 1.7.1 b/c 1.8.0 broke backward compatability for LSTM models. This has been fixed in 1.9.0, so we can just skip 1.8 versions.

Changes

  • Change Pytorch version to be above 1.7.0 but skip 1.8.0

Checklist

  • The title of your pull request should be a summary of its contribution.
  • Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • To indicate a work in progress please mark it as a draft on Github.
  • Make sure existing tests pass.
  • Add relevant tests. No quality testing = no merge.
  • All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

@jinyongyoo jinyongyoo self-assigned this Jul 22, 2021
@jinyongyoo jinyongyoo requested a review from sanchit97 July 22, 2021 14:19
@qiyanjun qiyanjun merged commit 776dfec into master Jul 22, 2021
@qiyanjun qiyanjun deleted the update-torch-version branch July 26, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants