Scrolling methods became deprecated#385
Merged
TikhomirovSergey merged 6 commits intoMay 9, 2016
Merged
Conversation
- The ScrollsTo interface was marked deprecated.
- all copied&pasted code was removed/wrapped inside methods and constructors - now everything looks systemically and not raw.
- ScrollTest was removed - tests which check scrolling locators were added to AndroidElementTest and AndroidSearchingTest
- IOSScrollTest was removed - IOSScrollingSearchingTest was added instead
Contributor
Author
|
@SrinivasanTarget please review this @bootstraponline Could you please take a look at this PR too? |
Member
|
I like this PR :) Changes Looks good to me except a style fix i.e line break at, |
Contributor
Author
|
@SrinivasanTarget |
Member
|
👍 |
This was referenced May 9, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Scrolling methods became deprecated and they are going to be removed further.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
I think it has no reasons to support them anymore. It is recommended to use instead:
#342 Fix #366 scrollTo does NOT work on named element #342 ScrollToExact inconsistent in it's behavior #341 iOS - scrollTo and scrollToExact should parameterise the class name #197 UiScrollable Within A Context - Scrolling First Element #226 added a method "scrollTobyCellIndex" to scroll by index on IOSDriver and IOSElement class #190 and some other related things