Skip to content

Scrolling methods became deprecated#385

Merged
TikhomirovSergey merged 6 commits into
appium:masterfrom
TikhomirovSergey:scrooll_deprecated
May 9, 2016
Merged

Scrolling methods became deprecated#385
TikhomirovSergey merged 6 commits into
appium:masterfrom
TikhomirovSergey:scrooll_deprecated

Conversation

@TikhomirovSergey

@TikhomirovSergey TikhomirovSergey commented May 8, 2016

Copy link
Copy Markdown
Contributor

Change list

Scrolling methods became deprecated and they are going to be removed further.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

- The ScrollsTo interface was marked deprecated.
- all copied&pasted code was removed/wrapped inside methods and constructors

 - now everything looks systemically and not raw.
- ScrollTest was removed

- tests which check scrolling locators were added to AndroidElementTest and AndroidSearchingTest
- IOSScrollTest was removed

- IOSScrollingSearchingTest was added instead
@TikhomirovSergey

Copy link
Copy Markdown
Contributor Author

@SrinivasanTarget please review this

@bootstraponline Could you please take a look at this PR too?

@SrinivasanTarget

Copy link
Copy Markdown
Member

@TikhomirovSergey

TikhomirovSergey commented May 9, 2016

Copy link
Copy Markdown
Contributor Author

Shall we close #366 in favour of #385?

@SrinivasanTarget
Yes. After the merging of this PR.

@bootstraponline

Copy link
Copy Markdown
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants