Google Java Style validation#354
Conversation
|
We can perform checks through maven going forward from CI. |
|
Great to see our repo audit reports shows there are "0" errors and "7774" warnings that we can work out. |
|
@SrinivasanTarget I'm going to merge this PR with my own modification after source code improvement. @bootstraponline What do you think about this? I think it is much better solution than proposed here: |
|
I like your modification @TikhomirovSergey 👍 |
|
@TikhomirovSergey Added goals as per your comments :) |
|
👍 |
|
@TikhomirovSergey Have a query. Are we expecting this (https://github.com/TikhomirovSergey/java-client/blob/f64c9a189038af7915e17bbbd829c0f7cab6d262/src/test/java/io/appium/java_client/ios/IOSDriverTest.java#L71) to fail? |
|
Thanks for adding me:) |
👍 |
The addition to the PR #354

Change list
Checkstyle validation to ensure google java code style is followed or not
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Continuation of #346
@TikhomirovSergey @Jonahss @bootstraponline Please take a look at this PR :)