Skip to content

Fix circular references on LdapAutoConfiguration#5055

Merged
nobodyiam merged 3 commits into
apolloconfig:masterfrom
spaceluke:fix-circular-references-on-ldap
Dec 21, 2023
Merged

Fix circular references on LdapAutoConfiguration#5055
nobodyiam merged 3 commits into
apolloconfig:masterfrom
spaceluke:fix-circular-references-on-ldap

Conversation

@spaceluke
Copy link
Copy Markdown
Member

@spaceluke spaceluke commented Dec 19, 2023 •
edited
Loading

What's the purpose of this PR

Fix circular references on LdapAutoConfiguration

Which issue(s) this PR fixes:

Fixes ##5051

Brief changelog

Update SpringSecurityLDAPAuthAutoConfiguration

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 19, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (76ec52d) 49.62% compared to head (33b9ab7) 49.62%.

Files Patch % Lines
...lo/portal/spi/configuration/AuthConfiguration.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #5055   +/-   ##
=========================================
  Coverage     49.62%   49.62%           
  Complexity     1904     1904           
=========================================
  Files           372      372           
  Lines         11559    11558    -1     
  Branches       1127     1127           
=========================================
  Hits           5736     5736           
+ Misses         5483     5482    -1     
  Partials        340      340

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spaceluke
Copy link
Copy Markdown
Member Author

spaceluke commented Dec 19, 2023

Can I not write test code for this PR please?🥺

@spaceluke spaceluke changed the base branch from master to dependabot/maven/com.google.guava-guava-32.0.0-jre December 19, 2023 13:30
@spaceluke spaceluke changed the base branch from dependabot/maven/com.google.guava-guava-32.0.0-jre to master December 19, 2023 13:33
@nobodyiam
Copy link
Copy Markdown
Member

nobodyiam commented Dec 21, 2023

Considering the findings presented in report #5056, I believe it is reasonable to forego the creation of unit tests.
Would you please also update the CHANGES.md? I think it's valuable to let users know the fix.

@spaceluke
Copy link
Copy Markdown
Member Author

spaceluke commented Dec 21, 2023

Considering the findings presented in report #5056, I believe it is reasonable to forego the creation of unit tests. Would you please also update the CHANGES.md? I think it's valuable to let users know the fix.

Am I update on the right CHANGES file?

nobodyiam
nobodyiam reviewed Dec 21, 2023
View reviewed changes
Comment thread changes/changes-2.2.0.md Outdated
* [Fix the issue that namespace content being cleared when identical content is pasted into the namespace](https://github.com/apolloconfig/apollo/pull/4922)
* [feat(openapi): allow user create app via openapi](https://github.com/apolloconfig/apollo/pull/4954)
* [Support grayscale feature for non-properties namespaces](https://github.com/apolloconfig/apollo/pull/4952)
* [Fix circular references on LdapAutoConfiguration](https://github.com/apolloconfig/apollo/pull/5055)
Copy link
Copy Markdown
Member

@nobodyiam nobodyiam Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.2.0 was released. Please add the change to the https://github.com/apolloconfig/apollo/blob/master/CHANGES.md

Copy link
Copy Markdown
Member Author

@spaceluke spaceluke Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.2.0 was released. Please add the change to the https://github.com/apolloconfig/apollo/blob/master/CHANGES.md

added😃

nobodyiam
nobodyiam approved these changes Dec 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Dec 21, 2023
@nobodyiam nobodyiam merged commit 1cea083 into apolloconfig:master Dec 21, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 21, 2023
@nobodyiam nobodyiam added this to the 2.3.0 milestone Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@spaceluke @nobodyiam