Skip to content

Added github actions for basic build/test setup.#113

Merged
mbien merged 3 commits into
apache:masterfrom
mbien:gh-actions
Dec 27, 2021
Merged

Added github actions for basic build/test setup.#113
mbien merged 3 commits into
apache:masterfrom
mbien:gh-actions

Conversation

@mbien

@mbien mbien commented Dec 25, 2021

Copy link
Copy Markdown
Member
  • builds/tests on JDK 11 and 17
  • uploads junit report
  • disabled a failing test for now

mbien added 2 commits December 25, 2021 10:01
@mbien
Added build/test github action.
b5fb65d 
 - runs on JDK 11 and 17
 - reports test results
@mbien
Disable failing test.
2c6d1bb
@mbien mbien requested a review from snoopdave December 25, 2021 09:06
@mbien

mbien commented Dec 25, 2021

Copy link
Copy Markdown
Member Author

i think the junit report will start working once the yaml is in master.
should look like this: https://github.com/mbien/roller/runs/4631232068?check_suite_focus=true
and if something fails:
https://github.com/mbien/roller/runs/4631155838?check_suite_focus=true

@mbien

mbien commented Dec 25, 2021

Copy link
Copy Markdown
Member Author

added step for selenium tests (didn't know that geckodriver could run headless).

snoopdave
snoopdave approved these changes Dec 27, 2021
View reviewed changes

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very cool. I have not tried it out yet, but I see no reason not to merge.

@mbien

mbien commented Dec 27, 2021

Copy link
Copy Markdown
Member Author

awesome. I merge it, lets see if everything builds.

@mbien mbien merged commit 683ca63 into apache:master Dec 27, 2021
@mbien

mbien commented Dec 27, 2021

Copy link
Copy Markdown
Member Author

it builds and tests but it didn't upload the test report (it should appear on the list on the left i think)
https://github.com/apache/roller/actions/runs/1627718913

Don't know why because I tested it on my wip branch and it worked fine. (but its not so important tbh, the full log is recorded anyway in case something fails)

@mbien

mbien commented Dec 27, 2021

Copy link
Copy Markdown
Member Author

oh haha. It published it in he CodeQL action
https://github.com/apache/roller/actions/runs/1627718912

@mbien

mbien commented Dec 27, 2021

Copy link
Copy Markdown
Member Author

mikepenz/action-junit-report#40

@mbien mbien mentioned this pull request Dec 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snoopdave snoopdave snoopdave approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mbien @snoopdave