RATIS-2435. ratis-bom POM is not signed during release staging#1374
Merged
Conversation
Signed-off-by: OneSizeFitsQuorum <[email protected]>
OneSizeFitsQuorum
force-pushed
the
jira2435
branch
from
91531fc to
99b7339
Compare
adoroszlai
reviewed
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Thanks @OneSizeFitsQuorum for the patch. I wonder if we should make ratis-bom inherit from Apache parent POM like ratis main POM does:
Lines 18 to 23 in 2c5412c
Apache Pulsar's BOM does:
Contributor
|
Also, maybe it's a bit late at this point, but should we revert all BOM changes from |
Contributor
Author
|
Both solution is OK! And I believe this is the last issue for ratis-bom to release! |
adoroszlai
approved these changes
Mar 13, 2026
Contributor
|
I prefer inheriting from Apache parent, because it requires less duplication and ensures consistent behavior for other inherited items, like plugin versions. Current: |
adoroszlai
pushed a commit
that referenced
this pull request
Mar 13, 2026
(cherry picked from commit c9914ee)
Contributor
|
Thanks @OneSizeFitsQuorum for the fix. |
slfan1989
pushed a commit
to slfan1989/ratis
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/browse/RATIS-2435