RATIS-2425. make_rc.sh does not set version in ratis-bom#1367
Merged
Conversation
szetszwo
approved these changes
Mar 8, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for the review. |
adoroszlai
added a commit
that referenced
this pull request
Mar 8, 2026
(cherry picked from commit 1433b4c)
Contributor
There was a problem hiding this comment.
Well, I think we should remove these logic or we cann't not release rc2 which do not change version anymore. @adoroszlai
if ! git diff --name-only | grep -q ratis-bom/pom.xml; then
echo 'ratis-bom not updated by `mvn versions:set`' >&2
exit 1
fi
Contributor
Author
|
Sure, please feel free to remove it. |
Contributor
Author
|
BTW, since there was no vote about rc1, do we still need to bump to rc2, or can simply replace rc1 artifacts? |
Contributor
|
Just send the email @adoroszlai |
slfan1989
pushed a commit
to slfan1989/ratis
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Let
make_rc.shchange version in all modules. Fail the step ifratis-bom/pom.xmlis unchanged.https://issues.apache.org/jira/browse/RATIS-2425
How was this patch tested?
Locally tested the sanity check without adding
-DprocessAllModules.