Skip to content

RATIS-2422. TestNettyRpcProxy.testOfferRollbackOnAlreadyClosed fails with Host is null#1364

Merged
adoroszlai merged 1 commit into
apache:masterfrom
adoroszlai:RATIS-2422
Mar 6, 2026
Merged

RATIS-2422. TestNettyRpcProxy.testOfferRollbackOnAlreadyClosed fails with Host is null#1364
adoroszlai merged 1 commit into
apache:masterfrom
adoroszlai:RATIS-2422

Conversation

@adoroszlai

@adoroszlai adoroszlai commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Fix test failure:

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.249 s <<< FAILURE! -- in org.apache.ratis.netty.TestNettyRpcProxy
[ERROR] org.apache.ratis.netty.TestNettyRpcProxy.testOfferRollbackOnAlreadyClosed -- Time elapsed: 0.181 s <<< ERROR!
java.lang.IllegalArgumentException: Host is null in 0:0:0:0:0:0:0:0:40029
	at org.apache.ratis.util.NetUtils.createSocketAddr(NetUtils.java:90)
	at org.apache.ratis.util.NetUtils.createSocketAddr(NetUtils.java:60)
	at org.apache.ratis.netty.NettyClient.connect(NettyClient.java:47)
	at org.apache.ratis.netty.NettyRpcProxy$Connection.<init>(NettyRpcProxy.java:204)
	at org.apache.ratis.netty.NettyRpcProxy.<init>(NettyRpcProxy.java:276)
	at org.apache.ratis.netty.TestNettyRpcProxy.testOfferRollbackOnAlreadyClosed(TestNettyRpcProxy.java:79)

https://issues.apache.org/jira/browse/RATIS-2422

How was this patch tested?

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.314 s -- in org.apache.ratis.netty.TestNettyRpcProxy

CI:
https://github.com/adoroszlai/ratis/actions/runs/22760390675

@adoroszlai adoroszlai self-assigned this Mar 6, 2026
@adoroszlai adoroszlai added the test label Mar 6, 2026
szetszwo
szetszwo approved these changes Mar 6, 2026
View reviewed changes

@szetszwo szetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit 2c80564 into apache:master Mar 6, 2026
16 checks passed
@adoroszlai adoroszlai deleted the RATIS-2422 branch March 6, 2026 17:11
@adoroszlai

adoroszlai commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @szetszwo for the review.

adoroszlai added a commit that referenced this pull request Mar 6, 2026
@adoroszlai
RATIS-2422. TestNettyRpcProxy.testOfferRollbackOnAlreadyClosed fails …
0d36933 
…with `Host is null` (#1364)

(cherry picked from commit 2c80564)
slfan1989 pushed a commit to slfan1989/ratis that referenced this pull request May 6, 2026
@adoroszlai @slfan1989
RATIS-2422. TestNettyRpcProxy.testOfferRollbackOnAlreadyClosed fails …
5055b54 
…with `Host is null` (apache#1364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szetszwo szetszwo szetszwo approved these changes

@OneSizeFitsQuorum OneSizeFitsQuorum Awaiting requested review from OneSizeFitsQuorum

Assignees

@adoroszlai adoroszlai

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adoroszlai @szetszwo