RATIS-2379. Support returning applied index for ReadIndex#1332
Merged
Conversation
szetszwo
reviewed
Jan 7, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
@ivandika3 , Thanks for working on this!
Sorry that I reviewed this earlier but forgot to press "Submit review". Please see the comments inlined.
| interface ReadIndex { | ||
| String PREFIX = Read.PREFIX + ".read-index"; | ||
|
|
||
| String READ_INDEX_USE_APPLIED_INDEX_ENABLED_KEY = PREFIX + ".use.applied-index.enabled"; |
Contributor
There was a problem hiding this comment.
- Let's remove "
use", i.e.raft.server.read-index.applied-index.enabled. - The field names must be the same as the String value. Otherwise, the TestConfUtils will fail as shown in the CI.
It needs a setter method.
interface ReadIndex {
String PREFIX = Read.PREFIX + ".read-index";
String APPLIED_INDEX_ENABLED_KEY = PREFIX + ".applied-index.enabled";
boolean APPLIED_INDEX_ENABLED_DEFAULT = false;
static boolean appliedIndexEnabled(RaftProperties properties) {
return getBoolean(properties::getBoolean, APPLIED_INDEX_ENABLED_KEY,
APPLIED_INDEX_ENABLED_DEFAULT, getDefaultLog());
}
static void setAppliedIndexEnabled(RaftProperties properties, boolean enabled) {
setBoolean(properties::setBoolean, APPLIED_INDEX_ENABLED_KEY, enabled);
}
}| } else { | ||
| this.followerMaxGapThreshold = (long) (followerGapRatioMax * maxPendingRequests); | ||
| } | ||
| this.readIndexUseAppliedIndexEnabled = RaftServerConfigKeys.Read.ReadIndex |
| */ | ||
| CompletableFuture<Long> getReadIndex(Long readAfterWriteConsistentIndex) { | ||
| final long commitIndex = server.getRaftLog().getLastCommittedIndex(); | ||
| final long lastAppliedOrCommitIndex = readIndexUseAppliedIndexEnabled ? |
Contributor
There was a problem hiding this comment.
Let's just call it index instead of lastAppliedOrCommitIndex.
|
|
||
| | **Property** | `raft.server.read.read-index.use.applied-index.enabled` | | ||
| |:----------------|:--------------------------------------------------------------------------| | ||
| | **Description** | whether leader return applied index instead of commit index for ReadIndex | |
Contributor
There was a problem hiding this comment.
Suggestion: "whether applied index (instead of commit index) is used for ReadIndex"
Contributor
Author
There was a problem hiding this comment.
Thanks, this is more concise. Updated.
szetszwo
reviewed
Jan 8, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
@ivandika3 , thanks for the update! Just have a comment inlined about the names. Please take a look.
Comment on lines
+272
to
+281
| String READ_INDEX_APPLIED_INDEX_ENABLED_KEY = PREFIX + ".applied-index.enabled"; | ||
| boolean READ_INDEX_APPLIED_INDEX_ENABLED_DEFAULT = false; | ||
| static boolean readIndexAppliedIndexEnabled(RaftProperties properties) { | ||
| return getBoolean(properties::getBoolean, READ_INDEX_APPLIED_INDEX_ENABLED_KEY, | ||
| READ_INDEX_APPLIED_INDEX_ENABLED_DEFAULT, getDefaultLog()); | ||
| } | ||
|
|
||
| static void setReadIndexAppliedIndexEnabled(RaftProperties properties, boolean enabled) { | ||
| setBoolean(properties::setBoolean, READ_INDEX_APPLIED_INDEX_ENABLED_KEY, enabled); | ||
| } |
Contributor
There was a problem hiding this comment.
Let's remove the "readIndex" prefix from the fields and methods since the interface name already has it, i.e.
interface ReadIndex {
String PREFIX = Read.PREFIX + ".read-index";
String APPLIED_INDEX_ENABLED_KEY = PREFIX + ".applied-index.enabled";
boolean APPLIED_INDEX_ENABLED_DEFAULT = false;
static boolean appliedIndexEnabled(RaftProperties properties) {
return getBoolean(properties::getBoolean, APPLIED_INDEX_ENABLED_KEY,
APPLIED_INDEX_ENABLED_DEFAULT, getDefaultLog());
}
static void setAppliedIndexEnabled(RaftProperties properties, boolean enabled) {
setBoolean(properties::setBoolean, APPLIED_INDEX_ENABLED_KEY, enabled);
}
}(Since this is a public API, we have to be more meticulous.)
szetszwo
approved these changes
Jan 9, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for the review. |
adoroszlai
added a commit
that referenced
this pull request
Mar 6, 2026
)" This reverts commit 51f1e8e.
slfan1989
pushed a commit
to slfan1989/ratis
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Please refer to https://issues.apache.org/jira/browse/RATIS-2379
How was this patch tested?
Unit test.