[GH 8420] PHP Constructor code completion should not add [#Override] #8421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I only added a test for SelectedPropertyMethodsCreator - I did not find any tests for the PHPCompletionItem class. It would be nice if this could still be added in the next version since this behaviour creates annoying bugs. |
Contributor
Author
|
found it - will add some more tests |
NReib
force-pushed
the
BOverrideOnConstructor
branch
from
d3a44ed to
e17a2a3
Compare
Contributor
Author
|
Added more tests. |
junichi11
reviewed
Apr 13, 2025
Member
junichi11
left a comment
junichi11
left a comment
There was a problem hiding this comment.
Please add a white space after if. Thanks.
php/php.editor/src/org/netbeans/modules/php/editor/codegen/SinglePropertyMethodCreator.java
Outdated
Show resolved
Hide resolved
php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCompletionItem.java
Outdated
Show resolved
Hide resolved
Override Attribute on constructors in PHP leads to compile errors (See also apache#8334) - No longer add override on constructors
NReib
force-pushed
the
BOverrideOnConstructor
branch
from
e17a2a3 to
ad3d9c6
Compare
Member
|
Please separate screenshots before & after. Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override Attribute on constructors in PHP leads to compile errors (See also #8334)
before:
after:
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)