[INLONG-12121][SDK] Log remote server address on send timeout and server errors in DataProxy Go SDK - #12124
Merged
Merged
Conversation
…ver errors in DataProxy Go SDK
…ver errors in DataProxy Go SDK
gunli
approved these changes
May 15, 2026
luchunliang
approved these changes
May 18, 2026
dockerzhang
approved these changes
May 18, 2026
gunli
added a commit
to Tencent/game-log-sdk-go
that referenced
this pull request
May 27, 2026
Failure logs previously only showed the error and batch metadata, making it hard to tell which backend a failed write was targeting. Record the remote address at dispatch time and include it in every send/retry/timeout/heartbeat/server-error log path. - connpool: export getRemoteAddr as GetRemoteAddr so callers outside the package can reuse the RemoteAddr -> ConnContext.Endpoint fallback (handles UDP and peer-closed conns where RemoteAddr is nil). - tglog: add batchReq.lastSendServerAddr, set it in sendBatch right after fetching the conn, and surface it in the relevant logs. - tglog: also log a warn on server-error responses (previously silently translated to errServerError). Inspired by apache/inlong#12124.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12121
Motivation
Log remote server address on send timeout and server errors in DataProxy Go SDK to facilitate troubleshooting on the server side.
Modifications
Record the remote server address when sending batch messages and print it to the logs.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation