Core: Enable strict metadata cleanup by default#8599
Merged
amogh-jahagirdar merged 1 commit intoSep 20, 2023
Merged
Conversation
nastra
approved these changes
Sep 20, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM once spotless is happy
amogh-jahagirdar
force-pushed
the
enable-strict-cleanup-by-default
branch
from
abffbdd to
0df61ab
Compare
Contributor
Author
|
Actually I can remove the override for RestCatalog now that this is default. Let me clean that up as well. |
amogh-jahagirdar
force-pushed
the
enable-strict-cleanup-by-default
branch
from
0df61ab to
a32598a
Compare
aokolnychyi
approved these changes
Sep 20, 2023
rdblue
approved these changes
Sep 20, 2023
Contributor
|
Thanks, @amogh-jahagirdar! |
Contributor
Author
|
Thanks @nastra @rdblue @aokolnychyi for quick reviews on this. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables strict metadata cleanup by default for the 1.4.0 release (discussed in the 09/20 community sync).